* Re: /srv/bzr/emacs/trunk r104263: * src/term.c (Fresume_tty): Restore hooks before reinitializing.
[not found] <E1QMVO8-00089e-Ny@colonialone.fsf.org>
@ 2011-05-18 3:21 ` Glenn Morris
2011-05-18 12:01 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2011-05-18 3:21 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
When committing changes on behalf of other people, can/should you
refrain from reformatting existing ChangeLog entries? It makes it look
like the other person has changed more than they really did.
> author: Courtney Bane <emacs-bugs-7626@cbane.org>
> committer: Stefan Monnier <monnier@iro.umontreal.ca>
> === modified file 'src/ChangeLog'
> --- a/src/ChangeLog 2011-05-12 16:30:17 +0000
> +++ b/src/ChangeLog 2011-05-18 00:26:48 +0000
[...]
> - * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]: Rename
> - local vars `left' and `width' to `bar_area_x' and
> + * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
> + Rename local vars `left' and `width' to `bar_area_x' and
[lots of this kind of thing]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: /srv/bzr/emacs/trunk r104263: * src/term.c (Fresume_tty): Restore hooks before reinitializing.
2011-05-18 3:21 ` /srv/bzr/emacs/trunk r104263: * src/term.c (Fresume_tty): Restore hooks before reinitializing Glenn Morris
@ 2011-05-18 12:01 ` Stefan Monnier
2011-05-18 12:21 ` Andreas Schwab
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2011-05-18 12:01 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> When committing changes on behalf of other people, can/should you
> refrain from reformatting existing ChangeLog entries?
It's difficult. The temptation is much too strong.
Better would be not to show the ChangeLog in the diffs ;-0
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: /srv/bzr/emacs/trunk r104263: * src/term.c (Fresume_tty): Restore hooks before reinitializing.
2011-05-18 12:01 ` Stefan Monnier
@ 2011-05-18 12:21 ` Andreas Schwab
2011-05-18 12:43 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2011-05-18 12:21 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> When committing changes on behalf of other people, can/should you
>> refrain from reformatting existing ChangeLog entries?
>
> It's difficult. The temptation is much too strong.
> Better would be not to show the ChangeLog in the diffs ;-0
If you want to reformat a changelog entry you can always do it in a
separate commit (which is preferable anyway).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: /srv/bzr/emacs/trunk r104263: * src/term.c (Fresume_tty): Restore hooks before reinitializing.
2011-05-18 12:21 ` Andreas Schwab
@ 2011-05-18 12:43 ` Stefan Monnier
2011-05-18 13:50 ` Andreas Schwab
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2011-05-18 12:43 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
> If you want to reformat a changelog entry you can always do it in a
> separate commit (which is preferable anyway).
Too much trouble for my taste.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: /srv/bzr/emacs/trunk r104263: * src/term.c (Fresume_tty): Restore hooks before reinitializing.
2011-05-18 12:43 ` Stefan Monnier
@ 2011-05-18 13:50 ` Andreas Schwab
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2011-05-18 13:50 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> If you want to reformat a changelog entry you can always do it in a
>> separate commit (which is preferable anyway).
>
> Too much trouble for my taste.
It's pretty trivial to do.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-18 13:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1QMVO8-00089e-Ny@colonialone.fsf.org>
2011-05-18 3:21 ` /srv/bzr/emacs/trunk r104263: * src/term.c (Fresume_tty): Restore hooks before reinitializing Glenn Morris
2011-05-18 12:01 ` Stefan Monnier
2011-05-18 12:21 ` Andreas Schwab
2011-05-18 12:43 ` Stefan Monnier
2011-05-18 13:50 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).