unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Subject: Allow specifying services as symbols?
Date: Tue, 19 Oct 2010 20:07:46 +0200	[thread overview]
Message-ID: <m3fww2dpjh.fsf@quimbies.gnus.org> (raw)

It was suggested that we should allow specifying port names (e.g.,
"imap") as symbols, too, in addition to strings and numbers.  Any
objections to something like the following?

=== modified file 'src/process.c'
*** src/process.c	2010-10-08 10:14:47 +0000
--- src/process.c	2010-10-19 18:06:05 +0000
***************
*** 2977,2987 ****
  for a server process, it must be a valid name or address for the local
  host, and only clients connecting to that address will be accepted.
  
! :service SERVICE -- SERVICE is name of the service desired, or an
! integer specifying a port number to connect to.  If SERVICE is t,
! a random port number is selected for the server.  (If Emacs was
! compiled with getaddrinfo, a port number can also be specified as a
! string, e.g. "80", as well as an integer.  This is not portable.)
  
  :type TYPE -- TYPE is the type of connection.  The default (nil) is a
  stream type connection, `datagram' creates a datagram type connection,
--- 2977,2988 ----
  for a server process, it must be a valid name or address for the local
  host, and only clients connecting to that address will be accepted.
  
! :service SERVICE -- SERVICE is name of the service desired (a string
! or a symbol) or an integer specifying a port number to connect to.  If
! SERVICE is t, a random port number is selected for the server.  (If
! Emacs was compiled with getaddrinfo, a port number can also be
! specified as a string, e.g. "http", as well as an integer.  This is
! not portable.)
  
  :type TYPE -- TYPE is the type of connection.  The default (nil) is a
  stream type connection, `datagram' creates a datagram type connection,
***************
*** 3313,3318 ****
--- 3314,3323 ----
  	  sprintf (portbuf, "%ld", (long) XINT (service));
  	  portstring = portbuf;
  	}
+       else if (SYMBOLP (service))
+ 	{
+ 	  portstring = SDATA (SYMBOL_NAME (service));
+ 	}
        else
  	{
  	  CHECK_STRING (service);



-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




             reply	other threads:[~2010-10-19 18:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 18:07 Lars Magne Ingebrigtsen [this message]
2010-10-19 18:22 ` Allow specifying services as symbols? Eli Zaretskii
2010-10-19 19:09 ` Ted Zlatanov
2010-10-19 20:17   ` Chong Yidong
2010-10-19 21:25     ` Ted Zlatanov
2010-10-19 21:32 ` Davis Herring
2010-10-19 22:20   ` Chong Yidong
2010-10-19 23:46     ` Lars Magne Ingebrigtsen
2010-10-20 15:36       ` Stefan Monnier
2010-10-20 16:10         ` Chong Yidong
2010-10-20 16:21         ` Ted Zlatanov
2010-10-20 11:32     ` Ted Zlatanov
2010-10-20 11:52       ` Andreas Schwab
2010-10-20 12:29         ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fww2dpjh.fsf@quimbies.gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).