From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: Allow specifying services as symbols?
Date: Wed, 20 Oct 2010 06:32:34 -0500 [thread overview]
Message-ID: <87fww1je0d.fsf@lifelogs.com> (raw)
In-Reply-To: 8739s19648.fsf@stupidchicken.com
[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]
On Tue, 19 Oct 2010 18:20:55 -0400 Chong Yidong <cyd@stupidchicken.com> wrote:
CY> "Davis Herring" <herring@lanl.gov> writes:
>>> ! :service SERVICE -- SERVICE is name of the service desired (a string
>>> ! or a symbol) or an integer specifying a port number to connect to. If
>>> ! SERVICE is t, a random port number is selected for the server. (If
>>> ! Emacs was compiled with getaddrinfo, a port number can also be
>>> ! specified as a string, e.g. "http", as well as an integer. This is
>>> ! not portable.)
>>
>> As more of a philosophical objection than anything, t is a symbol.
CY> Hmm, good catch. So's nil.
OK, I will exclude t and nil. That was a problem with the patch (t was
converted to "t" and nil to "nil"). Thanks for catching that! Revised
version attached.
CY> So let's back up for a moment, here. Lars, could you provide an example
CY> that shows why it's convenient to allow symbols to name services?
The issue came up as a customization user-side problem and I suggested
allowing symbols. Using symbols is consistent with many other Emacs
facilities (too many to list) that use symbols to enumerate a small set
of choices. It makes customization simpler and less error-prone for
software that uses `make-network-process'. It doesn't really cost
anything. The only downside is that if in the future we decide to add
options to the :service parameter besides t and nil, they won't be easy
to retrofit.
It's really not a big deal though, so if you're concerned about the
downside I listed or any others, let's kill the idea.
Ted
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: make-network-connection-with-symbol-service.patch --]
[-- Type: text/x-diff, Size: 3397 bytes --]
=== modified file 'doc/lispref/processes.texi'
--- doc/lispref/processes.texi 2010-08-25 05:23:47 +0000
+++ doc/lispref/processes.texi 2010-10-20 11:18:48 +0000
@@ -1937,9 +1937,10 @@
@var{buffer-or-name} is @code{nil}, it means that the connection is not
associated with any buffer.
-The arguments @var{host} and @var{service} specify where to connect to;
-@var{host} is the host name (a string), and @var{service} is the name of
-a defined network service (a string) or a port number (an integer).
+The arguments @var{host} and @var{service} specify where to connect
+to; @var{host} is the host name (a string), and @var{service} is the
+name of a defined network service (a string or a symbol) or a port
+number (an integer).
@end defun
@node Network Servers
@@ -2076,10 +2077,10 @@
@item :service @var{service}
@var{service} specifies a port number to connect to, or, for a server,
-the port number to listen on. It should be a service name that
-translates to a port number, or an integer specifying the port number
-directly. For a server, it can also be @code{t}, which means to let
-the system select an unused port number.
+the port number to listen on. It should be a service name (a string
+or a symbol) that translates to a port number, or an integer
+specifying the port number directly. For a server, it can also be
+@code{t}, which means to let the system select an unused port number.
@item :family @var{family}
@var{family} specifies the address (and protocol) family for
=== modified file 'src/process.c'
--- src/process.c 2010-10-08 10:14:47 +0000
+++ src/process.c 2010-10-20 11:20:53 +0000
@@ -2978,10 +2978,11 @@
host, and only clients connecting to that address will be accepted.
:service SERVICE -- SERVICE is name of the service desired, or an
-integer specifying a port number to connect to. If SERVICE is t,
-a random port number is selected for the server. (If Emacs was
-compiled with getaddrinfo, a port number can also be specified as a
-string, e.g. "80", as well as an integer. This is not portable.)
+integer specifying a port number to connect to. If SERVICE is t, a
+random port number is selected for the server. A port number can also
+be specified as a string, e.g. "80", or a symbol whose name will be
+used, as well as an integer. This is not necessarily portable; either
+getaddrinfo or getservbyname will be used to look up the port number.
:type TYPE -- TYPE is the type of connection. The default (nil) is a
stream type connection, `datagram' creates a datagram type connection,
@@ -3303,6 +3304,11 @@
Otherwise, use getservbyname to lookup the service. */
if (!NILP (host))
{
+ /* Take a symbol as the service and convert it to a string. */
+ if (!NILP (service) && !EQ (service, Qt) && SYMBOLP (service))
+ {
+ service = Fsymbol_name (service);
+ }
/* SERVICE can either be a string or int.
Convert to a C string for later use by getaddrinfo. */
@@ -3347,6 +3353,12 @@
/* We end up here if getaddrinfo is not defined, or in case no hostname
has been specified (e.g. for a local server process). */
+ /* Take a symbol as the service and convert it to a string. */
+ if (!NILP (service) && !EQ (service, Qt) && SYMBOLP (service))
+ {
+ service = Fsymbol_name (service);
+ }
+
if (EQ (service, Qt))
port = 0;
else if (INTEGERP (service))
next prev parent reply other threads:[~2010-10-20 11:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 18:07 Allow specifying services as symbols? Lars Magne Ingebrigtsen
2010-10-19 18:22 ` Eli Zaretskii
2010-10-19 19:09 ` Ted Zlatanov
2010-10-19 20:17 ` Chong Yidong
2010-10-19 21:25 ` Ted Zlatanov
2010-10-19 21:32 ` Davis Herring
2010-10-19 22:20 ` Chong Yidong
2010-10-19 23:46 ` Lars Magne Ingebrigtsen
2010-10-20 15:36 ` Stefan Monnier
2010-10-20 16:10 ` Chong Yidong
2010-10-20 16:21 ` Ted Zlatanov
2010-10-20 11:32 ` Ted Zlatanov [this message]
2010-10-20 11:52 ` Andreas Schwab
2010-10-20 12:29 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fww1je0d.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).