unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Klaus Straubinger <KSNetz@Arcor.DE>
Subject: Re: url-history.el: variable url-history-track defined but not used
Date: Wed, 7 Dec 2005 16:41:00 +0100 (CET)	[thread overview]
Message-ID: <m3ek4ovrsj.fsf@P131831.SAP.Corp> (raw)
In-Reply-To: <E1Ej1G8-0005C3-Es@fencepost.gnu.org>

> I installed that simplification.  Thanks.

Unfortunately, url-history.el still has the definition of the variable
url-history-list despite the ChangeLog item

	* url-history.el (url-history-list): Var deleted.


Furthermore, I would like to suggest that the simplications done to
url-history.el could also be applied to url-cookie.el as in the
following patch:


--- url-cookie.el.orig	2005-07-04 14:17:02.000000000 +0200
+++ url-cookie.el	2005-12-07 16:36:00.000000000 +0100
@@ -448,11 +448,10 @@
 Default is 1 hour.  Note that if you change this variable outside of
 the `customize' interface after `url-do-setup' has been run, you need
 to run the `url-cookie-setup-save-timer' function manually."
-  :set (function (lambda (var val)
-		   (set-default var val)
-		   (and (featurep 'url)
-			(fboundp 'url-cookie-setup-save-timer)
-			(url-cookie-setup-save-timer))))
+  :set #'(lambda (var val)
+	   (set-default var val)
+	   (if (bound-and-true-p url-setup-done)
+	       (url-cookie-setup-save-timer)))
   :type 'integer
   :group 'url)
 
@@ -460,21 +459,12 @@
 (defun url-cookie-setup-save-timer ()
   "Reset the cookie saver timer."
   (interactive)
-  (ignore-errors
-    (cond ((fboundp 'cancel-timer) (cancel-timer url-cookie-timer))
-	  ((fboundp 'delete-itimer) (delete-itimer url-cookie-timer))))
+  (ignore-errors (cancel-timer url-cookie-timer))
   (setq url-cookie-timer nil)
   (if url-cookie-save-interval
-      (setq url-cookie-timer
-	    (cond
-	     ((fboundp 'run-at-time)
-	      (run-at-time url-cookie-save-interval
-			   url-cookie-save-interval
-			   'url-cookie-write-file))
-	     ((fboundp 'start-itimer)
-	      (start-itimer "url-cookie-saver" 'url-cookie-write-file
-			    url-cookie-save-interval
-			    url-cookie-save-interval))))))
+      (setq url-cookie-timer (run-at-time url-cookie-save-interval
+					  url-cookie-save-interval
+					  #'url-cookie-write-file))))
 
 (provide 'url-cookie)

  reply	other threads:[~2005-12-07 15:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-25 10:09 url-history.el: variable url-history-track defined but not used Klaus Straubinger
2005-11-28 15:31 ` Klaus Straubinger
2005-11-29  3:11   ` Richard M. Stallman
2005-11-30 16:59     ` Klaus Straubinger
2005-12-02  2:07       ` Richard M. Stallman
2005-12-02 15:41         ` Klaus Straubinger
2005-12-04 21:19           ` Richard M. Stallman
2005-12-07 15:41             ` Klaus Straubinger [this message]
2005-12-08  4:55               ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ek4ovrsj.fsf@P131831.SAP.Corp \
    --to=ksnetz@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).