From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Klaus Straubinger Newsgroups: gmane.emacs.devel Subject: Re: url-history.el: variable url-history-track defined but not used Date: Wed, 7 Dec 2005 16:41:00 +0100 (CET) Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1133977784 11895 80.91.229.2 (7 Dec 2005 17:49:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 7 Dec 2005 17:49:44 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 07 18:49:40 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ek3MM-0001u3-Ui for ged-emacs-devel@m.gmane.org; Wed, 07 Dec 2005 18:45:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ek3Mc-0000Yh-37 for ged-emacs-devel@m.gmane.org; Wed, 07 Dec 2005 12:45:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ek1Rz-0000lE-0v for emacs-devel@gnu.org; Wed, 07 Dec 2005 10:43:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ek1Rw-0000j3-Gx for emacs-devel@gnu.org; Wed, 07 Dec 2005 10:43:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ek1Rv-0000iq-Vv for emacs-devel@gnu.org; Wed, 07 Dec 2005 10:43:20 -0500 Original-Received: from [155.56.68.140] (helo=smtpde03.sap-ag.de) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ek1Sn-0001Zs-Fh for emacs-devel@gnu.org; Wed, 07 Dec 2005 10:44:13 -0500 Original-Received: from sap-ag.de (smtpde03) by smtpde03.sap-ag.de (out) with ESMTP id QAA16722 for ; Wed, 7 Dec 2005 16:42:50 +0100 (MEZ) Original-To: emacs-devel@gnu.org In-Reply-To: X-Mailer: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 X-SAP: out X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47120 Archived-At: > I installed that simplification. Thanks. Unfortunately, url-history.el still has the definition of the variable url-history-list despite the ChangeLog item * url-history.el (url-history-list): Var deleted. Furthermore, I would like to suggest that the simplications done to url-history.el could also be applied to url-cookie.el as in the following patch: --- url-cookie.el.orig 2005-07-04 14:17:02.000000000 +0200 +++ url-cookie.el 2005-12-07 16:36:00.000000000 +0100 @@ -448,11 +448,10 @@ Default is 1 hour. Note that if you change this variable outside of the `customize' interface after `url-do-setup' has been run, you need to run the `url-cookie-setup-save-timer' function manually." - :set (function (lambda (var val) - (set-default var val) - (and (featurep 'url) - (fboundp 'url-cookie-setup-save-timer) - (url-cookie-setup-save-timer)))) + :set #'(lambda (var val) + (set-default var val) + (if (bound-and-true-p url-setup-done) + (url-cookie-setup-save-timer))) :type 'integer :group 'url) @@ -460,21 +459,12 @@ (defun url-cookie-setup-save-timer () "Reset the cookie saver timer." (interactive) - (ignore-errors - (cond ((fboundp 'cancel-timer) (cancel-timer url-cookie-timer)) - ((fboundp 'delete-itimer) (delete-itimer url-cookie-timer)))) + (ignore-errors (cancel-timer url-cookie-timer)) (setq url-cookie-timer nil) (if url-cookie-save-interval - (setq url-cookie-timer - (cond - ((fboundp 'run-at-time) - (run-at-time url-cookie-save-interval - url-cookie-save-interval - 'url-cookie-write-file)) - ((fboundp 'start-itimer) - (start-itimer "url-cookie-saver" 'url-cookie-write-file - url-cookie-save-interval - url-cookie-save-interval)))))) + (setq url-cookie-timer (run-at-time url-cookie-save-interval + url-cookie-save-interval + #'url-cookie-write-file)))) (provide 'url-cookie)