unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Problem at backup-buffer for writable files in not writable dirs
@ 2005-03-10  9:17 JUAN-LEON Lahoz Garcia
  0 siblings, 0 replies; only message in thread
From: JUAN-LEON Lahoz Garcia @ 2005-03-10  9:17 UTC (permalink / raw)



Hi,

When you edit and save a writable file in a non writable dir, and you
use `backup-by-copying' to nil (the default), backup-buffer fails to
make a backup in the place you define with `backup-directory-alist'
(because you cannot move files that are in a not writable dir), so it
copies it to file "~/%backup%~".

[ I know this is not very usual, but I have to edit some conf files in
  such directories and I got this ~/%backup%~ file around all the time ]

IMHO this one-liner patch solves the problem, by detecting this
situation as one of the cases where a copy should be used to backup
the file. You may want to review and/or apply it.

Regards
juanleon

--- files.el.ori	Thu Mar 10 09:29:31 2005
+++ files.el	Thu Mar 10 10:02:00 2005
@@ -2686,6 +2686,7 @@
 			      backup-by-copying
 			      ;; Don't rename a suid or sgid file.
 			      (and modes (< 0 (logand modes #o6000)))
+			      (not (file-writable-p (file-name-directory real-file-name)))
 			      (and backup-by-copying-when-linked
 				   (> (file-nlinks real-file-name) 1))
 			      (and (or backup-by-copying-when-mismatch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-03-10  9:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-10  9:17 Problem at backup-buffer for writable files in not writable dirs JUAN-LEON Lahoz Garcia

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).