From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: imagemagick format detection code
Date: Tue, 13 Aug 2013 20:14:39 +0200 [thread overview]
Message-ID: <m37gfp8nlc.fsf@stories.gnus.org> (raw)
In-Reply-To: <jwvmwolk74b.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 13 Aug 2013 10:23:32 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> This said, it's probably no worse than hacking up our own
> classification, so... yes, I guess it's a good plan. But please make
> them be symbols rather than strings:
>
> '((image/x-icon . "ico"))
I've now committed an attempt at this. That is, it works, and one can
now use duckduckgo.com and get nice images in the search results in eww,
but I'm not sure about the implementation.
Perhaps the rummaging around in the alist should have been done on the
elisp side instead of in C. I always feel that I'm doing something not
quite... good... when I'm writing Lisp in C:
suffix = Fcar (Fcdr (Fassq (content_type, Fsymbol_value (symbol))));
Anyway.
>>> We currently have a bit of a mess wrt to use of "format" and "type"
>>> since they're both used currently to refer to the same thing, which is
>>> not really the type or format of the image but rather something like the
>>> rendering library used.
>> Yes. This will add to the general confusion in this area.
>
> We should at least rework the doc to use "type" everywhere, so we can
> use :format for the new notion.
Yup.
--
(domestic pets only, the antidote for overdose, milk.)
No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html
next prev parent reply other threads:[~2013-08-13 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 21:14 imagemagick format detection code Lars Magne Ingebrigtsen
2013-08-11 21:27 ` Lars Magne Ingebrigtsen
2013-08-12 1:06 ` Stefan Monnier
2013-08-12 15:17 ` Lars Magne Ingebrigtsen
2013-08-12 17:43 ` Thien-Thi Nguyen
2013-08-13 14:23 ` Stefan Monnier
2013-08-13 18:14 ` Lars Magne Ingebrigtsen [this message]
2013-08-13 18:19 ` Lars Magne Ingebrigtsen
2013-08-13 18:56 ` Stefan Monnier
2013-08-13 19:05 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37gfp8nlc.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).