unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: imagemagick format detection code
Date: Mon, 12 Aug 2013 17:17:39 +0200	[thread overview]
Message-ID: <m361vblyzw.fsf@stories.gnus.org> (raw)
In-Reply-To: <jwv1u5zu3hs.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 11 Aug 2013 21:06:13 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> and feed that into `create-image' (er...  ":guessed-suffix"?) and then
>> set it with that function.
>
> :guessed-suffix sounds like a hack.  Maybe a :format argument would be
> better (and the ImageMagick could turn it into a file suffix).

Or we could explicit and call it :content-type, since that's what it
is.  But that may lead callers to expect that it (always) be heeded
instead of treating it as a hint.  Uhm...  :content-type-hint?

And then, as you say, the ImageMagick code in image.c will do the right
thing.

For instance, have an alist where the initial population is just

'(("image/x-icon" "ico"))

and we'd set the file name to (say) "/tmp/foo.ico" before asking
ImageMagick to parse the data blob.

If this doesn't seem too gruesome, I can implement this, and we'll see
whether there are further elements that should be added after a while...

> We currently have a bit of a mess wrt to use of "format" and "type"
> since they're both used currently to refer to the same thing, which is
> not really the type or format of the image but rather something like the
> rendering library used.

Yes.  This will add to the general confusion in this area.

-- 
(domestic pets only, the antidote for overdose, milk.)
  No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
  and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html



  reply	other threads:[~2013-08-12 15:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-11 21:14 imagemagick format detection code Lars Magne Ingebrigtsen
2013-08-11 21:27 ` Lars Magne Ingebrigtsen
2013-08-12  1:06   ` Stefan Monnier
2013-08-12 15:17     ` Lars Magne Ingebrigtsen [this message]
2013-08-12 17:43       ` Thien-Thi Nguyen
2013-08-13 14:23       ` Stefan Monnier
2013-08-13 18:14         ` Lars Magne Ingebrigtsen
2013-08-13 18:19           ` Lars Magne Ingebrigtsen
2013-08-13 18:56           ` Stefan Monnier
2013-08-13 19:05             ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m361vblyzw.fsf@stories.gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).