unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org,  sbaugh@janestreet.com
Subject: Re: Upstreaming url-http-ntlm.el
Date: Mon, 17 Apr 2023 15:07:26 -0400	[thread overview]
Message-ID: <m34jpel441.fsf@fitzsim.org> (raw)
In-Reply-To: <83v8ik7pw2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Mar 2023 20:21:49 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
>> Cc: Spencer Baugh <sbaugh@janestreet.com>
>> Date: Tue, 28 Mar 2023 11:10:01 -0400
>> 
>> Hi,
>> 
>> Spencer made the following suggestion:
>> 
>> Spencer Baugh <sbaugh@janestreet.com> writes:
>> 
>> > It would be nice if url-http-ntlm was packaged with core Emacs, because
>> > (in my experience) there are lots of corporate proxies which require
>> > NTLM authentication to even reach the outside internet and thereby
>> > download packages such as url-http-ntlm.  So there's a chicken and egg
>> > problem.
>> >
>> > Have you considered upstreaming this package, to resolve this problem?
>> 
>> I think this rationale for having url-http-ntlm bundled into the Emacs
>> release tarball is strong.  Any objections?
>
> No objections, but it "needs work" before it can be included.  At the
> very least, its main entry point should be documented in url.texi, and
> some minor code and documentation cleanup is in order.  I also am not
> sure we want to keep the change log at the end of the file.

Noted, I'll fix those before pushing; thanks for reviewing.

>> If not, in what release could it be included?
>
> Since it "needs work", I think it should go to master.

OK, thanks.  Spencer is trying to fix bug#62598.  I'll hold off adding
url-http-ntlm to master until that bug is fixed.

>> And, what is the procedure for including it?
>
> From my POV, see above.  If the maintainers want to keep the package
> on ELPA as well, then Stefan and Philip should probably chime in and
> tell what is required on their part.

I would maintain it on the Emacs master branch, but also make it
available in GNU ELPA, for use by older Emacs versions, like I do with
ntlm.el.

Thomas



      reply	other threads:[~2023-04-17 19:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ier4jqfl7f5.fsf@janestreet.com>
2023-03-28 15:10 ` Upstreaming url-http-ntlm.el Thomas Fitzsimmons
2023-03-28 17:21   ` Eli Zaretskii
2023-04-17 19:07     ` Thomas Fitzsimmons [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34jpel441.fsf@fitzsim.org \
    --to=fitzsim@fitzsim.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).