From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: Upstreaming url-http-ntlm.el Date: Mon, 17 Apr 2023 15:07:26 -0400 Message-ID: References: <83v8ik7pw2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12842"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 17 21:08:15 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poUCz-00035g-MY for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Apr 2023 21:08:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poUCL-0004Bf-0y; Mon, 17 Apr 2023 15:07:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poUCK-0004AU-09 for emacs-devel@gnu.org; Mon, 17 Apr 2023 15:07:32 -0400 Original-Received: from mail.fitzsim.org ([69.165.165.189]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poUCI-0004fE-11; Mon, 17 Apr 2023 15:07:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s0ODrOIJPlEmv8P3JrhTjIjkRALGN/4bXsvPYPPF1l8=; b=e23o7pg9ZDY8b90ZtWyRFVI+7r +4WHIrAtE0+gChXi8BMgAiq9c6G1LxINxUVwpBtTfAYNYIa6PywVNK4NJJZfsMbyUhwjdzQDRdr2m Diygsrb3psh5e4RTWUE8SkX8pIKB0YeY4g72Fp0NSH1tIiOln6u65/fif4FOVinhBB8GoLJ8Qh5LJ dNAYZKzQhD9syBOpHh4Rx4qAL2KJ2GWPq3ah14u+1JLX4kmJwe2v4P61hn9YYE0jrdcVYI6sLE9ai huikJ4Zvr93AUhzvkBtrmcBa7eIIGwDF2fkx4Ol1iSo9hC+6ic4lKMCTQiIMG/tAoKdieG8MKjtBk 2g/AyZ5A==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1poUCE-000MlF-Fs; Mon, 17 Apr 2023 15:07:26 -0400 In-Reply-To: <83v8ik7pw2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Mar 2023 20:21:49 +0300") Received-SPF: pass client-ip=69.165.165.189; envelope-from=fitzsim@fitzsim.org; helo=mail.fitzsim.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305385 Archived-At: Eli Zaretskii writes: >> From: Thomas Fitzsimmons >> Cc: Spencer Baugh >> Date: Tue, 28 Mar 2023 11:10:01 -0400 >> >> Hi, >> >> Spencer made the following suggestion: >> >> Spencer Baugh writes: >> >> > It would be nice if url-http-ntlm was packaged with core Emacs, because >> > (in my experience) there are lots of corporate proxies which require >> > NTLM authentication to even reach the outside internet and thereby >> > download packages such as url-http-ntlm. So there's a chicken and egg >> > problem. >> > >> > Have you considered upstreaming this package, to resolve this problem? >> >> I think this rationale for having url-http-ntlm bundled into the Emacs >> release tarball is strong. Any objections? > > No objections, but it "needs work" before it can be included. At the > very least, its main entry point should be documented in url.texi, and > some minor code and documentation cleanup is in order. I also am not > sure we want to keep the change log at the end of the file. Noted, I'll fix those before pushing; thanks for reviewing. >> If not, in what release could it be included? > > Since it "needs work", I think it should go to master. OK, thanks. Spencer is trying to fix bug#62598. I'll hold off adding url-http-ntlm to master until that bug is fixed. >> And, what is the procedure for including it? > > From my POV, see above. If the maintainers want to keep the package > on ELPA as well, then Stefan and Philip should probably chime in and > tell what is required on their part. I would maintain it on the Emacs master branch, but also make it available in GNU ELPA, for use by older Emacs versions, like I do with ntlm.el. Thomas