From: Filipp Gunbin <fgunbin@fastmail.fm>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: comments about jsonrpc.el
Date: Fri, 01 Jun 2018 23:00:39 +0300 [thread overview]
Message-ID: <m2efhq46qg.fsf@fgunbin.playteam.ru> (raw)
I was reading the last jsonrpc.el from jsonrpc-refactor branch in eglot
repo and got few comments. Sorry if I'm misreading something.
1) When deferred action times out, the timer clears continuations and
calls timeout-fn. I think it should also clear deferred actions, so
they are not called from next jsonrpc--connection-receive afterwards.
2) When deferred action runs, it invokes jsonrpc-async-request which
invokes jsonrpc-connection-send. I think we should also clear
deferred actions here (why leave them?). Also, there seem to be two
ways to handle timer: a) take timer from deferred action and save it
in continuation - then its timeout spans both 'wait until server
ready' interval and actual response wait interval; b) cancel deferred
action timer and create new timer - it's done in the current code.
3) When deferred action runs, jsonrpc--async-request-1 should be
called with 'deferred' non-nil - so it actually sends request. But
it's unclear to me how this deferred=t is passed there ('apply' call
on line 621)
4) jsonrpc--async-request-1 - non-local exit is missing (I saw it in
the version you posted here)
5) jsonrpc-request: there's unwind-protect with some cleanup. Seems
that we also need to clean deferred actions and cancel timer (that is
in continuation). Another option - maybe we can just bind
inhibit-quit to t instead of this unwind-protect with cleanup?
Filipp
next reply other threads:[~2018-06-01 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 20:00 Filipp Gunbin [this message]
2018-06-02 0:42 ` comments about jsonrpc.el João Távora
2018-06-06 20:43 ` Filipp Gunbin
2018-06-10 11:39 ` João Távora
2018-06-13 19:09 ` Filipp Gunbin
2018-06-13 19:21 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2efhq46qg.fsf@fgunbin.playteam.ru \
--to=fgunbin@fastmail.fm \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).