unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Filipp Gunbin <fgunbin@fastmail.fm>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: comments about jsonrpc.el
Date: Wed, 13 Jun 2018 22:09:19 +0300	[thread overview]
Message-ID: <m2efha5wrk.fsf@fgunbin.playteam.ru> (raw)
In-Reply-To: <87vaaq6fb2.fsf@gmail.com> ("João Távora"'s message of "Sun, 10 Jun 2018 12:39:45 +0100")

Hi João,

On 10/06/2018 12:39 +0100, João Távora wrote:

> In the newer version it doesn't say that, but even in that version I am
> pretty sure that `make-timer' was a lambda that checks the `timer`
> variable before actually making one.

No, that version didn't check the `timer' var inside the lambda..

> BTW, it's better to use diffs to highlight source code bits, it provides
> context, people do it quite extensively in this group.  Also add the git
> commit hash (or if the code comes from an email, indicate the origin of
> the email )

Yep, I don't know why I didn't post the diff :-)

Thanks
Filipp



  reply	other threads:[~2018-06-13 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 20:00 comments about jsonrpc.el Filipp Gunbin
2018-06-02  0:42 ` João Távora
2018-06-06 20:43   ` Filipp Gunbin
2018-06-10 11:39     ` João Távora
2018-06-13 19:09       ` Filipp Gunbin [this message]
2018-06-13 19:21         ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2efha5wrk.fsf@fgunbin.playteam.ru \
    --to=fgunbin@fastmail.fm \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).