From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: "João Távora" <joaotavora@gmail.com>
Subject: Re: master 67c3a3a 2/2: Avoid occasional confusion of Flymake C/C++ backend
Date: Tue, 26 Mar 2019 15:01:29 +0100 [thread overview]
Message-ID: <m2ef6tag5i.fsf@gmail.com> (raw)
In-Reply-To: <20190325145634.E71A520535@vcs0.savannah.gnu.org> (unknown@unknown.invalid's message of "Mon, 25 Mar 2019 10:56:34 -0400 (EDT)")
>>>>> On Mon, 25 Mar 2019 10:56:34 -0400 (EDT), Unknown <unknown@unknown.invalid> said:
João> branch: master commit
João> 67c3a3af1d9e2582193d5ea33b6c190e79ad56e6 Author: João Távora
João> <joaotavora@gmail.com> Commit: João Távora
João> <joaotavora@gmail.com>
João> Avoid occasional confusion of Flymake C/C++ backend
João> The regexp would sometimes match non-errors and create a
João> diagnostic with nil severity, which would have consequences
João> for the Flymake engine (these should eventually be
João> addressed, too).
This is making flymake-tests fail:
Test different-diagnostic-types condition:
(ert-test-failed
((should
(eq 'flymake-error
(face-at-point)))
:form
(eq flymake-error flymake-note)
:value nil))
FAILED 1/9 different-diagnostic-types (1.093461 sec)
(face-at-point) is flymake-note there.
Robert
next parent reply other threads:[~2019-03-26 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190325145632.633.72531@vcs0.savannah.gnu.org>
[not found] ` <20190325145634.E71A520535@vcs0.savannah.gnu.org>
2019-03-26 14:01 ` Robert Pluim [this message]
2019-03-27 17:43 ` master 67c3a3a 2/2: Avoid occasional confusion of Flymake C/C++ backend João Távora
2019-03-27 12:23 ` master updated (5fdf4fc -> 67c3a3a) Glenn Morris
2019-03-27 12:50 ` Robert Pluim
2019-03-27 18:04 ` João Távora
2019-03-27 18:23 ` Dmitry Gutov
2019-03-28 7:34 ` Robert Pluim
2019-03-28 17:35 ` João Távora
2019-03-28 19:05 ` João Távora
2019-07-01 22:28 ` Ken Brown
2019-07-01 22:40 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ef6tag5i.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).