From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 67c3a3a 2/2: Avoid occasional confusion of Flymake C/C++ backend Date: Tue, 26 Mar 2019 15:01:29 +0100 Message-ID: References: <20190325145632.633.72531@vcs0.savannah.gnu.org> <20190325145634.E71A520535@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="108239"; mail-complaints-to="usenet@blaine.gmane.org" Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 26 15:08:04 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8mkG-000S12-73 for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2019 15:08:04 +0100 Original-Received: from localhost ([127.0.0.1]:60605 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8mkC-00080f-5i for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2019 10:08:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8me3-0004Ga-0N for emacs-devel@gnu.org; Tue, 26 Mar 2019 10:01:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8me1-0001QA-2t for emacs-devel@gnu.org; Tue, 26 Mar 2019 10:01:38 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:36892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8mdy-0001Oi-WA for emacs-devel@gnu.org; Tue, 26 Mar 2019 10:01:35 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id v14so13066862wmf.2 for ; Tue, 26 Mar 2019 07:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=7q5TO/uin1bgqoiY06omg2qguRAm8aes8Yld9057hU0=; b=VqMJrEZZUWxDpjFQvIb7rs7m2ylc08a8PdY9mHJ9+q4CP3fCYgHon+qjcK7nZT5UEw A3kC1qKEO3ZKR/C62rpObI/mXLKI5oF/rmWi4GC1tCJwe0qoOPpr/9sqpbIPnGiFFfsC LW2V5lz/RfzaFDmOOf3ytbO/ifFdYbWxcuEjIhGY/g/eSIPll+jan8KKi01a1nQ2z6dH hgCps0Z4n56x575QEBPsGXlICFqGGxBzbdNTlqhjW/Ccn6x7sdKYa1MqQfVKW86NJhqB 1VrgCMcvEA2Uq86HDXtg8XzBWAhP579SavjTuHn1IXyWoE2V1syvfQHNUIxWOp3IprL8 faWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=7q5TO/uin1bgqoiY06omg2qguRAm8aes8Yld9057hU0=; b=FmnzHLKbwDy/5lJInBMFEQtTZw5S5n+rMOM5CDHqij+G0pfE3tU1PQ1mtjOOp9TkRg 2n/YjOPy+5nmvQ5y47nfuPJGPkw5x6RRqrHuhDt6ZY6sb2y+wzFl2SRK1NV9rg2NWV8L 8kMzakmNQED1coDseSuIiyKC/gjAuDxirUwkZy0O3Ez+y635ctUjW6aQ+AZXjgXQMT7T UgC4wdFK628xD7U08szTogTJ6WfYsufuYSyclAzceO1K5I02t0i4ofqlMCiXkeuSIwyI wnIb8EEYrl5e0YPcpZUlDr58NSxtX+NPC5L9r3ixUQJfflzeiUVs+xevJyZoDCso8tCM dPzA== X-Gm-Message-State: APjAAAVU/ZCOg3ysN4Ex4eRHA7aT0+ny5iyYxSRVgKMpFWmSA1E43//G ByPIe/yLqKMaFKuRySNVung= X-Google-Smtp-Source: APXvYqx4o6d/S474FZy1WWQaYFK2SN38xcXseuw618WxTvzv4veNuMAlu1uR0d3jxMjmP8jjHa/iyQ== X-Received: by 2002:a1c:1f49:: with SMTP id f70mr14821492wmf.147.1553608891675; Tue, 26 Mar 2019 07:01:31 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id y8sm16939692wrm.8.2019.03.26.07.01.30 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 26 Mar 2019 07:01:30 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <20190325145634.E71A520535@vcs0.savannah.gnu.org> (unknown@unknown.invalid's message of "Mon, 25 Mar 2019 10:56:34 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::330 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234743 Archived-At: >>>>> On Mon, 25 Mar 2019 10:56:34 -0400 (EDT), Unknown said: Jo=C3=A3o> branch: master commit Jo=C3=A3o> 67c3a3af1d9e2582193d5ea33b6c190e79ad56e6 Author: Jo=C3=A3o T= =C3=A1vora Jo=C3=A3o> Commit: Jo=C3=A3o T=C3=A1vora Jo=C3=A3o> Jo=C3=A3o> Avoid occasional confusion of Flymake C/C++ backend =20=20=20=20 Jo=C3=A3o> The regexp would sometimes match non-errors and create a Jo=C3=A3o> diagnostic with nil severity, which would have consequences Jo=C3=A3o> for the Flymake engine (these should eventually be Jo=C3=A3o> addressed, too). This is making flymake-tests fail: Test different-diagnostic-types condition: (ert-test-failed ((should (eq 'flymake-error (face-at-point))) :form (eq flymake-error flymake-note) :value nil)) FAILED 1/9 different-diagnostic-types (1.093461 sec) =20=20=20=20=20=20=20 (face-at-point) is flymake-note there. Robert