unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] add some things to pure-fns
@ 2017-09-24 16:55 Mark Oteiza
  2017-09-24 23:20 ` John Wiegley
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Oteiza @ 2017-09-24 16:55 UTC (permalink / raw)
  To: emacs-devel

Based on the discussion here:
https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00953.html
which also continues this month,

the following shouldn't make anything explode, since all these
functions return integers.

diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el
index 962a7ae5cd..297e43884f 100644
--- a/lisp/emacs-lisp/byte-opt.el
+++ b/lisp/emacs-lisp/byte-opt.el
@@ -1281,7 +1281,10 @@ byte-optimize-set
 ;; errors to compile time.
 
 (let ((pure-fns
-       '(concat symbol-name regexp-opt regexp-quote string-to-syntax)))
+       '(concat symbol-name regexp-opt regexp-quote string-to-syntax
+         string-to-char
+         ash lsh logb lognot logior logxor
+         ceiling floor)))
   (while pure-fns
     (put (car pure-fns) 'pure t)
     (setq pure-fns (cdr pure-fns)))



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] add some things to pure-fns
  2017-09-24 16:55 [PATCH] add some things to pure-fns Mark Oteiza
@ 2017-09-24 23:20 ` John Wiegley
  0 siblings, 0 replies; 2+ messages in thread
From: John Wiegley @ 2017-09-24 23:20 UTC (permalink / raw)
  To: Mark Oteiza; +Cc: emacs-devel

>>>>> "MO" == Mark Oteiza <mvoteiza@udel.edu> writes:

MO> the following shouldn't make anything explode, since all these functions
MO> return integers.

Looks fine to me.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-24 23:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-24 16:55 [PATCH] add some things to pure-fns Mark Oteiza
2017-09-24 23:20 ` John Wiegley

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).