unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: coccinelle patch suggestion
Date: Wed, 27 Jun 2012 23:03:01 +0200	[thread overview]
Message-ID: <m28vf8ead6.fsf@igel.home> (raw)
In-Reply-To: <yxq1ul0brwp.fsf@fencepost.gnu.org> (Dan Nicolaescu's message of "Wed, 27 Jun 2012 13:12:22 -0400")

Dan Nicolaescu <dann@gnu.org> writes:

> Many lisp functions are declared in header files using the EXFUN macro,
> like this:
> EXFUN (Finteractive_form, 1);
>
> this might have been good when wanting to support both pre-standard C
> and standard  C, but we don't support the former anymore.

It generates a prototype, which is useful in standard C.

> And EXFUN just adds an unneeded level of obfuscation that doesn't help
> code readability.

It tells you that it's a Lisp function with N arguments.  That's easier
to read than when you need to count them.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



  reply	other threads:[~2012-06-27 21:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 17:12 coccinelle patch suggestion Dan Nicolaescu
2012-06-27 21:03 ` Andreas Schwab [this message]
2012-06-28  0:06   ` John Wiegley
2012-06-28 12:39     ` Dmitry Antipov
2012-06-28 18:05       ` Stefan Monnier
2012-06-29 16:36         ` Tom Tromey
2012-07-02 18:12           ` Stefan Monnier
2012-07-02 19:05             ` Tom Tromey
2012-07-03 13:24               ` Stefan Monnier
2012-07-02 15:40         ` Samuel Bronson
2012-07-02 17:11           ` Tom Tromey
2012-06-27 21:24 ` Stefan Monnier
2012-06-27 21:45   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m28vf8ead6.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=dann@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).