unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dmitry Antipov <dmantipov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: coccinelle patch suggestion
Date: Mon, 02 Jul 2012 13:05:31 -0600	[thread overview]
Message-ID: <87395ax9tw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <jwvhatqrq53.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 02 Jul 2012 14:12:13 -0400")

Tom> What do you think of the appended?

Stefan> I think it's going in the right direction.  I do wonder/worry about
Stefan> handling dependencies: for the current globals.h, there's no real
Stefan> problem since if the vars in it can be pretty much only missing or
Stefan> extraneous but can't be incorrect (they *very* rarely change type), but
Stefan> it's slightly less rare to change the type of a DEFUN'd function
Stefan> (i.e. adding/removing arguments).

I think dependencies should already work fine.

gl-stamp is rebuilt when a source file changes:

    gl-stamp: $(libsrc)/make-docfile$(EXEEXT) $(GLOBAL_SOURCES)

Then this is used to rebuild global.h if the contents change:

    globals.h: gl-stamp; @true

Is there a particular scenario you are concerned with?
I could give it a try.

Tom



  reply	other threads:[~2012-07-02 19:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 17:12 coccinelle patch suggestion Dan Nicolaescu
2012-06-27 21:03 ` Andreas Schwab
2012-06-28  0:06   ` John Wiegley
2012-06-28 12:39     ` Dmitry Antipov
2012-06-28 18:05       ` Stefan Monnier
2012-06-29 16:36         ` Tom Tromey
2012-07-02 18:12           ` Stefan Monnier
2012-07-02 19:05             ` Tom Tromey [this message]
2012-07-03 13:24               ` Stefan Monnier
2012-07-02 15:40         ` Samuel Bronson
2012-07-02 17:11           ` Tom Tromey
2012-06-27 21:24 ` Stefan Monnier
2012-06-27 21:45   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87395ax9tw.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).