unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change
Date: Wed, 17 Apr 2019 17:09:23 +0200	[thread overview]
Message-ID: <m27ebsy8gs.fsf@gmail.com> (raw)
In-Reply-To: <m2bm14y8xj.fsf@gmail.com> (Robert Pluim's message of "Wed, 17 Apr 2019 16:59:20 +0200")

>>>>> On Wed, 17 Apr 2019 16:59:20 +0200, Robert Pluim <rpluim@gmail.com> said:

>>>>> On Wed, 17 Apr 2019 08:40:25 -0600, Alex Gramiak <agrambot@gmail.com> said:
    Alex> Robert Pluim <rpluim@gmail.com> writes:
    >>>>>>>> On Wed, 17 Apr 2019 08:12:26 -0600, Alex Gramiak
    >>>>>>>> <agrambot@gmail.com> said:
    >>> 
    Alex> I pushed fixes for these, thanks.
    >>> 
    >>> CCLD temacs Undefined symbols for architecture x86_64:
    >>> "_gui_destroy_all_bitmaps", referenced from:
    >>> _ns_delete_terminal in nsterm.o ld: symbol(s) not found for
    >>> architecture x86_64
    >>> 
    >>> image.c and xterm.c call it image_destroy_all_bitmaps,
    >>> w32fns.c calls it x_destroy_all_bitmaps.
    >>> 
    >>> Robert

    Alex> image_* is the correct one, thanks. I pushed a fix for both.

    Robert> Now it builds and runs. I haven't tried on Ubuntu, but
    Robert> will do that later.

Although building on macOS '--with-x=no --with-ns=no' gives the same
kind of errors as on emba, eg <https://emba.gnu.org/emacs/emacs/-/jobs/1399/raw>

because clear_under_internal_border depends on HAVE_WINDOW_SYSTEM

xdisp.c:11595:34: error: no member named 'clear_under_internal_border' in
      'struct redisplay_interface'
              if (FRAME_RIF (f)->clear_under_internal_border)
                  ~~~~~~~~~~~~~  ^
xdisp.c:11596:32: error: no member named 'clear_under_internal_border' in
      'struct redisplay_interface'
                FRAME_RIF (f)->clear_under_internal_border (f);
                ~~~~~~~~~~~~~  ^
xdisp.c:11666:34: error: no member named 'clear_under_internal_border' in
      'struct redisplay_interface'
              if (FRAME_RIF (f)->clear_under_internal_border)
                  ~~~~~~~~~~~~~  ^
xdisp.c:11667:32: error: no member named 'clear_under_internal_border' in
      'struct redisplay_interface'
                FRAME_RIF (f)->clear_under_internal_border (f);
                ~~~~~~~~~~~~~  ^
xdisp.c:14491:38: error: no member named 'clear_under_internal_border' in
      'struct redisplay_interface'
                  if (FRAME_RIF (f)->clear_under_internal_border)
                      ~~~~~~~~~~~~~  ^
xdisp.c:14492:36: error: no member named 'clear_under_internal_border' in
      'struct redisplay_interface'
                    FRAME_RIF (f)->clear_under_internal_border (f);



  reply	other threads:[~2019-04-17 15:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190416165204.7024.23185@vcs0.savannah.gnu.org>
     [not found] ` <20190416165207.442F52068F@vcs0.savannah.gnu.org>
2019-04-16 17:05   ` scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change Robert Pluim
2019-04-16 17:18     ` Alex Gramiak
2019-04-16 18:05       ` Eli Zaretskii
2019-04-17 14:15         ` Alex Gramiak
2019-04-17  8:24       ` Robert Pluim
2019-04-17 14:12         ` Alex Gramiak
2019-04-17 14:29           ` Robert Pluim
2019-04-17 14:40             ` Alex Gramiak
2019-04-17 14:59               ` Robert Pluim
2019-04-17 15:09                 ` Robert Pluim [this message]
2019-04-17 15:39                   ` Alex Gramiak
2019-04-17 15:46                     ` Robert Pluim
2019-04-18 21:03                       ` Alex Gramiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m27ebsy8gs.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).