From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change Date: Wed, 17 Apr 2019 17:09:23 +0200 Message-ID: References: <20190416165204.7024.23185@vcs0.savannah.gnu.org> <20190416165207.442F52068F@vcs0.savannah.gnu.org> <87zhopc1ia.fsf@gmail.com> <87ef60bu0l.fsf@gmail.com> <875zrcbspy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="240271"; mail-complaints-to="usenet@blaine.gmane.org" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 17 17:10:29 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGmCi-0010Pl-Sa for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 17:10:28 +0200 Original-Received: from localhost ([127.0.0.1]:55141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGmCg-0003Af-K3 for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 11:10:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGmC0-0003AX-LQ for emacs-devel@gnu.org; Wed, 17 Apr 2019 11:09:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGmBy-0008VQ-Ou for emacs-devel@gnu.org; Wed, 17 Apr 2019 11:09:44 -0400 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:36072) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGmBw-0008DA-6L for emacs-devel@gnu.org; Wed, 17 Apr 2019 11:09:41 -0400 Original-Received: by mail-wr1-x42e.google.com with SMTP id y13so32470847wrd.3 for ; Wed, 17 Apr 2019 08:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=dshb9C61o1UayCclY7a5D9y/p0StL6uAX5iuC76IB3U=; b=OSJBaU1zA/3946Y9VqQNOF9RJK7kHGeIfkNLgV3e1ChIcBkWbXbgNOYZPlfH8HjE5E psm8OMGj509psabSEWQ6164VrZV4eQKQr3vOs+a7s4km2LWMGNWYoyODTb5QJ3gJTAeB Y5wEVNA+9he5c7tM2pUu2MfrcuUexMFE0Kzd1mc13eVuliHHamx0BA8Ht/Gui16HjTpX 5O4okacmzFU8L/+vIyrA8uzP62N5m8jYc3gxo2101PITqV9rZli5IbWzyLNgqcBh1Rl1 i1VGZZv7SM0++iEox9gDvMzZUqHXxL5pMoP7z1WaOjDhbxxAAMtrqgDYxE6WRHOJl+t4 qctQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version; bh=dshb9C61o1UayCclY7a5D9y/p0StL6uAX5iuC76IB3U=; b=UdYUhmYHE4Ct9tG2okvEd3c9iSvVnbBS1EoJf07sY9RP5IR3lT4FbD/GaAtlGHVMd7 M3MUCW2cfp5xHxrgBkCzeQSyqq7eX1nGD/AGppCzvo5y85Gh7Il0SQo+3BFaykwQfRrk 0XWW/3CHbD6tg+Usrww6HpxTAMIBA1o6Wy4UzOK0hpCT7pdCMahAV8C9XRbC43znylBK 9KriI+f/lOaR7elV6wROdw03LBhmhROMU5k1xZ5Q2QiknWWmwEumB63bN3LSeeZbu54B 2lQ/BC/2QwCBjYwi3P3ZVShb7GuxDtqShWgAks4TdMWae2kJJKfa7u5Wd8RIuPvYlGoS GMEA== X-Gm-Message-State: APjAAAUFcZnR4rxDebifpuv6eYSw4o/FK/6HOzCjXsbyFAF1ngQAXHDm yvFF2CgIRxSZouCWzEYXusSqeW41 X-Google-Smtp-Source: APXvYqwg77A4lnPWaIoVQHEtsAYe5Hw6twUJBbgpmPjjxJRhvI0Q0CTZdzNO6lOsES07+zKIVpe9EQ== X-Received: by 2002:adf:f607:: with SMTP id t7mr8773660wrp.191.1555513764996; Wed, 17 Apr 2019 08:09:24 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id u10sm3104627wml.32.2019.04.17.08.09.23 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 17 Apr 2019 08:09:24 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Robert Pluim's message of "Wed, 17 Apr 2019 16:59:20 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235582 Archived-At: >>>>> On Wed, 17 Apr 2019 16:59:20 +0200, Robert Pluim said: >>>>> On Wed, 17 Apr 2019 08:40:25 -0600, Alex Gramiak said: Alex> Robert Pluim writes: >>>>>>>> On Wed, 17 Apr 2019 08:12:26 -0600, Alex Gramiak >>>>>>>> said: >>> Alex> I pushed fixes for these, thanks. >>> >>> CCLD temacs Undefined symbols for architecture x86_64: >>> "_gui_destroy_all_bitmaps", referenced from: >>> _ns_delete_terminal in nsterm.o ld: symbol(s) not found for >>> architecture x86_64 >>> >>> image.c and xterm.c call it image_destroy_all_bitmaps, >>> w32fns.c calls it x_destroy_all_bitmaps. >>> >>> Robert Alex> image_* is the correct one, thanks. I pushed a fix for both. Robert> Now it builds and runs. I haven't tried on Ubuntu, but Robert> will do that later. Although building on macOS '--with-x=no --with-ns=no' gives the same kind of errors as on emba, eg because clear_under_internal_border depends on HAVE_WINDOW_SYSTEM xdisp.c:11595:34: error: no member named 'clear_under_internal_border' in 'struct redisplay_interface' if (FRAME_RIF (f)->clear_under_internal_border) ~~~~~~~~~~~~~ ^ xdisp.c:11596:32: error: no member named 'clear_under_internal_border' in 'struct redisplay_interface' FRAME_RIF (f)->clear_under_internal_border (f); ~~~~~~~~~~~~~ ^ xdisp.c:11666:34: error: no member named 'clear_under_internal_border' in 'struct redisplay_interface' if (FRAME_RIF (f)->clear_under_internal_border) ~~~~~~~~~~~~~ ^ xdisp.c:11667:32: error: no member named 'clear_under_internal_border' in 'struct redisplay_interface' FRAME_RIF (f)->clear_under_internal_border (f); ~~~~~~~~~~~~~ ^ xdisp.c:14491:38: error: no member named 'clear_under_internal_border' in 'struct redisplay_interface' if (FRAME_RIF (f)->clear_under_internal_border) ~~~~~~~~~~~~~ ^ xdisp.c:14492:36: error: no member named 'clear_under_internal_border' in 'struct redisplay_interface' FRAME_RIF (f)->clear_under_internal_border (f);