unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Doug Davis <ddavis@ddavis.io>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: Revert recent buggy font-locking changes in python.el
Date: Thu, 04 Mar 2021 10:26:54 -0500	[thread overview]
Message-ID: <m25z277xdt.fsf@ddavis.io> (raw)
In-Reply-To: <877dmnw3x1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Mar 2021 12:31:54 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Doug Davis <ddavis@ddavis.io> writes:
>
>> (Bug#45679) and (Bug#46233) report buggy font-locking in python.el. I
>> was able to trace it back to b2ce94fa5e - but I haven't been able to
>> figure out _what_ the bug is (it's easy to trigger the issue, i.e.
>> trigger the wonky font-locking), but not obvious how it's happening).
>>
>> Would it be reasonable to revert those changes (the attached patch does
>> it)? I would also be happy to help solve the underlying issue (by
>> testing new patches or being pointed to any tips for debugging font
>> locking issues).
>
> The patch seemed to fix the issue in bug#45341, so it'd be better to try
> to determine what it doesn't get right instead of reverting outright.

Thanks, understood- I'll keep poking at it (and repeat that I'm happy to
volunteer to test any patches if anyone else tries to work on it and
believes they have a fix).



  parent reply	other threads:[~2021-03-04 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 21:28 Revert recent buggy font-locking changes in python.el Doug Davis
2021-03-04 11:31 ` Lars Ingebrigtsen
2021-03-04 14:12   ` Eli Zaretskii
2021-03-04 15:26   ` Doug Davis [this message]
2021-03-04 23:56 ` Daniel Martín
2021-03-05  1:22   ` Doug Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m25z277xdt.fsf@ddavis.io \
    --to=ddavis@ddavis.io \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).