From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Doug Davis Newsgroups: gmane.emacs.devel Subject: Re: Revert recent buggy font-locking changes in python.el Date: Thu, 04 Mar 2021 10:26:54 -0500 Message-ID: References: <877dmnw3x1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19806"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 16:29:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHpuv-00052F-RL for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 16:29:33 +0100 Original-Received: from localhost ([::1]:56186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHpus-0007EB-TV for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 10:29:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHpsS-0005Qw-Qp for emacs-devel@gnu.org; Thu, 04 Mar 2021 10:27:00 -0500 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:34167) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHpsQ-0008Ag-Mh for emacs-devel@gnu.org; Thu, 04 Mar 2021 10:27:00 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E1D5112E7; Thu, 4 Mar 2021 10:26:56 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 04 Mar 2021 10:26:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ddavis.io; h= from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=fm1; bh=QoAa4etlj0YIllULMYevdAKgvZ mtmEgsfwPH+riYDeQ=; b=gZuCHTuF5B+PYn82sn9NehAcT/PKBs4dcFJ2DCeGJN mZMJemCg8TFusXewyigU0vXKRy00tSqCJiMyWphdNIgTKKAprACvQT1Up/s3+TMz dNOfganKhSOgmebm6wh6kaymyK4NK+U/N+qwXiJ7EC2Dnn1SmvyUgzNqbgk2bp28 ZXfl5+cVKdCaOtrPp9eJv8wWjQMBQW/TL7y8WytUKOjq78RO9TYY8anf33nDWoJ/ m4blwa89XS2k0Vu1dQipWH+CS0jrLEM6GpkoMQDBT7l9Kxr4KWeH8I742Rpvyfyt bg6DtQt5x4RtRTuGlp03eewAxZCYohqAgjxycu4AV22A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QoAa4e tlj0YIllULMYevdAKgvZmtmEgsfwPH+riYDeQ=; b=ICcAH8wiDXKdqscF2kthjq vhyCQb7hScGSf/K+HEK3jmvbGxuK3j6QWi+/YoEy+cH2K6Odpez2a9ubr85/DIOd FmYI55dhXens8QVqxkNIUSEeOPB++K1zSayflqJ04NR6koAVP2b5iFCESJ2yRcyb cNs4L2XOUQwK4xFak4l7aYsva7BqqBdVxmEp4exazA1dp/9A+Kd3jd+RHj5EnXDx a6mCy6PY3EYjFC5EfJCzmMCJNUwzwyvKCHMoExmEHxLb0FF/+ju2xXeT+oLkBF68 wrlOZNsLkekFafUIZKR7qXruXTcvTgUALwHGUeux9DjiKUHTmOjDYVHtDBMQjG1A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtgedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpeffohhughcu ffgrvhhishcuoeguuggrvhhishesuggurghvihhsrdhioheqnecuggftrfgrthhtvghrnh epgedtveffudeitdelveevkeeitedtleehgedugeeludfhheejffekjeffgeffleejnecu kfhppedvgedrleekrdejiedrkedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepuggurghvihhsseguuggrvhhishdrihho X-ME-Proxy: Original-Received: from localhost (c-24-98-76-80.hsd1.ga.comcast.net [24.98.76.80]) by mail.messagingengine.com (Postfix) with ESMTPA id 10C1D1080068; Thu, 4 Mar 2021 10:26:56 -0500 (EST) In-Reply-To: <877dmnw3x1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Mar 2021 12:31:54 +0100") Received-SPF: pass client-ip=64.147.123.20; envelope-from=ddavis@ddavis.io; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265967 Archived-At: Lars Ingebrigtsen writes: > Doug Davis writes: > >> (Bug#45679) and (Bug#46233) report buggy font-locking in python.el. I >> was able to trace it back to b2ce94fa5e - but I haven't been able to >> figure out _what_ the bug is (it's easy to trigger the issue, i.e. >> trigger the wonky font-locking), but not obvious how it's happening). >> >> Would it be reasonable to revert those changes (the attached patch does >> it)? I would also be happy to help solve the underlying issue (by >> testing new patches or being pointed to any tips for debugging font >> locking issues). > > The patch seemed to fix the issue in bug#45341, so it'd be better to try > to determine what it doesn't get right instead of reverting outright. Thanks, understood- I'll keep poking at it (and repeat that I'm happy to volunteer to test any patches if anyone else tries to work on it and believes they have a fix).