[patch] bug-reference.el

[patch] bug-reference.el

[Arne Jørgensen]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi,

I think bug-reference.el is missing a "(provide 'bug-reference)".

And I would suggest changing `bug-reference-bug-regexp' from a constant
to a variable and marking it as safe-local-variable for
`string-or-null-p'. This way it is possible to bind it in .dir-locals.el
like it is already possible to bind `bug-reference-url-format'.

Kind regards,
Arne


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bug-reference.patch --]
[-- Type: text/x-patch, Size: 817 bytes --]

--- bug-reference.el-OLD	2012-07-19 14:09:15.000000000 +0200
+++ bug-reference.el	2012-07-19 14:07:17.000000000 +0200
@@ -61,10 +61,13 @@
            (and (symbolp s)
                 (get s 'bug-reference-url-format)))))
 
-(defconst bug-reference-bug-regexp
+(defvar bug-reference-bug-regexp
   "\\([Bb]ug ?#\\|[Pp]atch ?#\\|RFE ?#\\|PR [a-z-+]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)"
   "Regular expression which matches bug references.")
 
+;;;###autoload
+(put 'bug-reference-bug-regexp 'safe-local-variable 'string-or-null-p)
+
 (defun bug-reference-set-overlay-properties ()
   "Set properties of bug reference overlays."
   (put 'bug-reference 'evaporate t)
@@ -154,4 +157,6 @@
       (widen)
       (bug-reference-unfontify (point-min) (point-max)))))
 
+(provide 'bug-reference)
+
 ;;; bug-reference.el ends here

Re: [patch] bug-reference.el

[Arne Jørgensen]

Arne Jørgensen <arne@arnested.dk> writes:

> And I would suggest changing `bug-reference-bug-regexp' from a constant
> to a variable and marking it as safe-local-variable for
> `string-or-null-p'. This way it is possible to bind it in .dir-locals.el
> like it is already possible to bind `bug-reference-url-format'.

Glenn Morris committed a similar solution in 109739.

Thanks.

Arne