Re: /srv/bzr/emacs/trunk r103471: Add a menu-bar entry for Artist mode.

Re: /srv/bzr/emacs/trunk r103471: Add a menu-bar entry for Artist mode.

[Leo]

On 2011-03-02 11:48 +0800, Chong Yidong wrote:
> ------------------------------------------------------------
> revno: 103471
> committer: Chong Yidong <cyd@stupidchicken.com>
> branch nick: trunk
> timestamp: Tue 2011-03-01 22:48:01 -0500
> message:
>   Add a menu-bar entry for Artist mode.
>   
>   * lisp/textmodes/artist.el (artist-curr-go): Default to pen-line.
>   (artist-select-op-pen-line): New function.
>   (artist-menu-map): New variable.
>   (artist-mode-map): Add a menu to the menu-bar.
[...]

Using this patch with Emacs-23 (GNU Emacs 23.3.1
x86_64-apple-darwin10.6.0, sorry I haven't had Emacs-24 yet.), I can get
an error when doing this:

1. Emacs -q
2. M-x artist-mode
3. From the artist menu choose Poly-line and draw a line
4. From the artist menu choose Spray can

Then I get this backtrace:

Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  artist-endpoint-get-x(nil)
  artist-set-arrow-points-for-poly(([46 13]))
  artist-mouse-draw-poly((down-mouse-1 (#<window 3 on *scratch*> 288 (106 . 195) 374939930 nil 288 (13 . 13) nil (106 . 0) (8 . 15))))
  artist-down-mouse-1((down-mouse-1 (#<window 3 on *scratch*> 288 (106 . 195) 374939930 nil 288 (13 . 13) nil (106 . 0) (8 . 15))))
  call-interactively(artist-down-mouse-1 nil nil)

Cheers,
Leo

Re: /srv/bzr/emacs/trunk r103471: Add a menu-bar entry for Artist mode.

[Chong Yidong]

Leo <sdl.web@gmail.com> writes:

>>   * lisp/textmodes/artist.el (artist-curr-go): Default to pen-line.
>>   (artist-select-op-pen-line): New function.
>>   (artist-menu-map): New variable.
>>   (artist-mode-map): Add a menu to the menu-bar.
>
> Using this patch with Emacs-23 (GNU Emacs 23.3.1
> x86_64-apple-darwin10.6.0, sorry I haven't had Emacs-24 yet.), I can get
> an error when doing this:
>
> 1. Emacs -q
> 2. M-x artist-mode
> 3. From the artist menu choose Poly-line and draw a line
> 4. From the artist menu choose Spray can

It's not an error with the patch; if you use the equivalent keyboard
commands, the same error pops up.  It seems to be a problem with the
implementation of artist-mode's poly-line operation.  I'll take a look
when I have the time.