Re: master 70341cab3e: string-equal-ignore-case: new function

Re: master 70341cab3e: string-equal-ignore-case: new function

[Lars Ingebrigtsen]

Sam Steingold <sds@gnu.org> writes:

> -;; case-insensitive case, but it has to cope with null args.
> -;; (`string-equal' uses symbol print names.)
> -(defun gnus-string-equal (x y)
> -  "Like `string-equal', except it compares case-insensitively."
> -  (and (= (length x) (length y))
> -       (or (string-equal x y)
> -	   (string-equal (downcase x) (downcase y)))))

We don't remove non-internal functions like this (because they may be
used by third parties).  Instead make it obsolete.

> -	      (when (gnus-string-equal
> +	      (when (string-equal-ignore-case
>  		     (message-fetch-field "followup-to")
>  		     (message-fetch-field "newsgroups"))

And the arguments here may be nil, which will signal an error.

Re: master 70341cab3e: string-equal-ignore-case: new function

[Sam Steingold]

> * Lars Ingebrigtsen <ynefv@tahf.bet> [2022-07-26 19:58:06 +0200]:
>
> Sam Steingold <sds@gnu.org> writes:
>
>> -;; case-insensitive case, but it has to cope with null args.
>> -;; (`string-equal' uses symbol print names.)
>> -(defun gnus-string-equal (x y)
>> -  "Like `string-equal', except it compares case-insensitively."
>> -  (and (= (length x) (length y))
>> -       (or (string-equal x y)
>> -	   (string-equal (downcase x) (downcase y)))))
>
> We don't remove non-internal functions like this (because they may be
> used by third parties).  Instead make it obsolete.

fixed, thanks.

>> -	      (when (gnus-string-equal
>> +	      (when (string-equal-ignore-case
>>  		     (message-fetch-field "followup-to")
>>  		     (message-fetch-field "newsgroups"))
>
> And the arguments here may be nil, which will signal an error.

I thought I checked all uses of `gnus-string-equal', sorry...

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://mideasttruth.com https://camera.org http://think-israel.org
char*a="char*a=%c%s%c;main(){printf(a,34,a,34);}";main(){printf(a,34,a,34);}

Re: master 70341cab3e: string-equal-ignore-case: new function

[Roland Winkler]

On Tue, Jul 26 2022, Sam Steingold wrote:
> +(defun string-equal-ignore-case (string1 string2)
> +  "Like `string-equal', but case-insensitive.
> +Upper-case and lower-case letters are treated as equal.
> +Unibyte strings are converted to multibyte for comparison."
> +  (eq t (compare-strings string1 0 nil string2 0 nil t)))

Isn't this a perfect candidate for an inline function,
i.e., defsubst instead of defun?

Re: master 70341cab3e: string-equal-ignore-case: new function

[Sam Steingold]

> * Roland Winkler <jvaxyre@tah.bet> [2022-07-26 14:00:53 -0500]:
>
> On Tue, Jul 26 2022, Sam Steingold wrote:
>> +(defun string-equal-ignore-case (string1 string2)
>> +  "Like `string-equal', but case-insensitive.
>> +Upper-case and lower-case letters are treated as equal.
>> +Unibyte strings are converted to multibyte for comparison."
>> +  (eq t (compare-strings string1 0 nil string2 0 nil t)))
>
> Isn't this a perfect candidate for an inline function,
> i.e., defsubst instead of defun?

Probably...
I can probably add more declarations...

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://www.peaceandtolerance.org/ https://camera.org
Whether pronounced "leenooks" or "line-uks", it's better than Windows.