23 branch NS build failure - XVECTOR->size / nsmenu

23 branch NS build failure - XVECTOR->size / nsmenu

[David Reitter]

The use of XVECTOR()->size needs to be changed (e.g., to ASIZE()) in nsmenu's ns_update_menubar to make the 23 branch compile again (with NS).

This change from the trunk would be the right one to merge:

revno: 104024 [merge]
committer: Paul Eggert <eggert@cs.ucla.edu>
branch nick: trunk
timestamp: Tue 2011-04-26 23:03:54 -0700
message:
  Merge: nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.


Is this something I can do myself (and if so, how - i.e., what's the correct way to cherry-pick in Bzr?), or should I wait for a maintainer to do it?

Re: 23 branch NS build failure - XVECTOR->size / nsmenu

[Glenn Morris]

David Reitter wrote:

> Is this something I can do myself (and if so, how - i.e., what's the
> correct way to cherry-pick in Bzr?), or should I wait for a maintainer
> to do it?

Somebody already reported this and provided a patch:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8839

Personally I don't see any point in applying it until/unless it's
confirmed there will be another release from emacs-23 (currently, there
is not expected to be one,
http://lists.gnu.org/archive/html/emacs-devel/2011-06/msg00289.html )

Re: 23 branch NS build failure - XVECTOR->size / nsmenu

[Alp Aker]

> The use of XVECTOR()->size needs to be changed (e.g., to ASIZE()) in 
> nsmenu's  ns_update_menubar to make  the 23 branch compile again 
> (with NS).

I reported this as well in:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8839

and supplied a patch.  It might be easier to apply that directly rather than 
trying to cherry pick from the trunk.

Re: 23 branch NS build failure - XVECTOR->size / nsmenu

[Alp Aker]

> Personally I don't see any point in applying it until/unless it's
> confirmed there will be another release from emacs-23.

But wouldn't it be unfortunate to leave emacs-23 in a state in 
which it won't even compile on NS?

Re: 23 branch NS build failure - XVECTOR->size / nsmenu

[Glenn Morris]

Alp Aker wrote:

> But wouldn't it be unfortunate to leave emacs-23 in a state in 
> which it won't even compile on NS?

It doesn't bother me, any more than the fact that it doesn't compile on
some GNU/Linux distributions:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8497

I'd rather spend effort on getting 24.1 in shape. If somebody else wants
to backport these fixes, that's fine by me, but I'm not going to bother.

bug#8839: 23 branch NS build failure - XVECTOR->size / nsmenu

[David Reitter]

On Jun 15, 2011, at 3:29 PM, Alp Aker wrote:
> 
> But wouldn't it be unfortunate to leave emacs-23 in a state in 
> which it won't even compile on NS?

I agree.  I have made the change (rev 100598).  Please try it out.

Re: 23 branch NS build failure - XVECTOR->size / nsmenu

[Alp Aker]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

On Thu, Jun 16, 2011 at 12:31 PM, David Reitter wrote:

> I agree.  I have made the change (rev 100598).  Please try it out.

Builds fine.  Thanks for installing the fix.

[-- Attachment #2: Type: text/html, Size: 216 bytes --]