activate region with S-mouse-1

activate region with S-mouse-1

[Dominic Jänichen]

I am using shift-select-mode and want to activate a region using S-
mouse-1. I have <mouse-1> and <S-mouse-1> bound to "mouse-set-point". I 
either change "mouse-set-point" to contain (interactive "^e") or use cua-
mode and (put 'mouse-set-point 'CUA 'move).
I find that I can then extend existing regions with <S-mouse-1>, but not 
activate one (ie. click on some spot to activate the region between that 
spot and the current mark).

This issue exists since rev 107888 and is documented there: "Don't 
activate the region on shift if the binding is already shifted." That's 
fine for <left> as <S-left> translates to <left>, but <S-mouse-1> does 
not translate to <mouse-1>. The only option is to bind <S-mouse-1>, but 
this does not activate the region as it is already shifted.

What is a proper fix, here? Modifying read_key_sequence to set "this-
command-keys-shift-translated" to "t" if the command is bound to shifted 
mouse-events? Or using a specific handler for <S-mouse-1>?


Dominic

Re: activate region with S-mouse-1

[Stefan Monnier]

> This issue exists since rev 107888 and is documented there: "Don't 
> activate the region on shift if the binding is already shifted." That's 
> fine for <left> as <S-left> translates to <left>, but <S-mouse-1> does 
> not translate to <mouse-1>.

Yes, S-mouse-1 does translate to mouse-1, tho only if S-mouse-1 is
not bound.  So instead of binding S-mouse-1 to mouse-set-point, you want
to unbind S-mouse-1: (global-set-key [S-mouse-1] nil)


        Stefan

Re: activate region with S-mouse-1

[Dominic Jänichen]

On Fri, 28 Mar 2014 16:19:19 -0400, Stefan Monnier wrote:

> S-mouse-1 does translate to mouse-1, tho only if S-mouse-1 is not
> bound.  So instead of binding S-mouse-1 to mouse-set-point, you want to
> unbind S-mouse-1: (global-set-key [S-mouse-1] nil)

Doing that results in S-Mouse-1 being non-functional. ("<S-mouse-1> is 
undefined" in minibuffer.)

Dominic

Re: activate region with S-mouse-1

[Stefan Monnier]

>> S-mouse-1 does translate to mouse-1, tho only if S-mouse-1 is not
>> bound.  So instead of binding S-mouse-1 to mouse-set-point, you want to
>> unbind S-mouse-1: (global-set-key [S-mouse-1] nil)
> Doing that results in S-Mouse-1 being non-functional. ("<S-mouse-1> is 
> undefined" in minibuffer.)

Hmm...  Could you make a bug report for it?


        Stefan

Re: activate region with S-mouse-1

[Dominic Jänichen]

On Fri, 28 Mar 2014 18:38:47 -0400, Stefan Monnier wrote:

> Hmm...  Could you make a bug report for it?

Sure. #17140.

There is also a stale one (#11575) that should be closed instead.


Dominic