From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames.
Date: Thu, 06 Sep 2012 13:37:03 -0400 [thread overview]
Message-ID: <jwvzk53ys13.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5048D826.3040103@yandex.ru> (Dmitry Antipov's message of "Thu, 06 Sep 2012 21:06:46 +0400")
>> In 99% of the cases, it's easy to distinguish: one can be GC'd and the
>> other can't.
> From GC's point of view; if you look at window pointer and W->hchild,
> W-> vchild and W->buffer are all Qnil, you still don't know whether W
> is recorded in some window configuration object.
If you're looking at W, that means there's a reference to it, and
assuming that window is deleted, I say there's a 99% chance that the
reference to it comes from a window-config.
> Hm... it was definitely wrong for the windows because deleted window
> may be "a little more alive" than deleted buffer or frame; but I still think
> that treating "deleted/killed" object as "dead enough to not
> look inside too much" is good enough for the rest.
Let's do it field-by-field (and by setting to field to NULL/nil, which
is a safer way to get the same result) rather than in one big jump into
the unknown.
Stefan
next prev parent reply other threads:[~2012-09-06 17:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1T9II0-0005q4-Gh@vcs.savannah.gnu.org>
2012-09-05 18:24 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames Stefan Monnier
2012-09-05 19:15 ` Stefan Monnier
2012-09-06 6:55 ` Dmitry Antipov
2012-09-06 7:00 ` Herring, Davis
2012-09-06 7:28 ` martin rudalics
2012-09-06 9:57 ` Dmitry Antipov
2012-09-06 14:42 ` martin rudalics
2012-09-06 12:53 ` Stefan Monnier
2012-09-06 14:42 ` martin rudalics
2012-09-06 12:52 ` Stefan Monnier
2012-09-06 14:42 ` martin rudalics
2012-09-06 17:33 ` Stefan Monnier
2012-09-07 9:52 ` martin rudalics
2012-09-06 17:06 ` Dmitry Antipov
2012-09-06 17:37 ` Stefan Monnier [this message]
2012-09-07 9:53 ` martin rudalics
2012-09-07 15:19 ` Stefan Monnier
2012-09-10 9:46 ` Reachable killed buffers [Was: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames] Dmitry Antipov
2012-09-10 13:25 ` Stefan Monnier
2012-09-10 15:15 ` Reachable killed buffers Dmitry Antipov
2012-09-10 20:15 ` Stefan Monnier
2012-09-10 21:10 ` Stefan Monnier
2012-09-11 5:25 ` Dmitry Antipov
2012-09-11 13:06 ` Stefan Monnier
2012-09-12 8:09 ` martin rudalics
2012-09-12 13:47 ` Paul Eggert
2012-09-12 13:59 ` Dmitry Antipov
2012-09-12 14:05 ` Paul Eggert
2012-09-12 14:15 ` martin rudalics
2012-09-12 15:59 ` Dmitry Antipov
2012-09-12 17:37 ` martin rudalics
2012-09-12 17:55 ` Paul Eggert
2012-09-13 3:29 ` Stefan Monnier
2012-09-13 4:43 ` Paul Eggert
2012-09-13 5:00 ` Dmitry Antipov
2012-09-13 5:18 ` Paul Eggert
2012-09-13 12:47 ` Stefan Monnier
2012-09-13 16:49 ` martin rudalics
2012-09-13 17:11 ` Paul Eggert
2012-09-13 17:30 ` martin rudalics
2012-09-14 12:10 ` Dmitry Antipov
2012-09-14 13:29 ` Stefan Monnier
2012-09-14 13:38 ` martin rudalics
2012-09-13 18:01 ` Dmitry Antipov
2012-09-06 7:20 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzk53ys13.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).