From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames. Date: Thu, 06 Sep 2012 13:37:03 -0400 Message-ID: References: <504848D0.4020908@yandex.ru> <5048D826.3040103@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1346953029 19261 80.91.229.3 (6 Sep 2012 17:37:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2012 17:37:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 06 19:37:12 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T9g0t-0004Xc-EP for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2012 19:37:11 +0200 Original-Received: from localhost ([::1]:42618 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9g0q-0003zN-CP for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2012 13:37:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9g0n-0003z6-Lv for emacs-devel@gnu.org; Thu, 06 Sep 2012 13:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9g0m-0002iO-H6 for emacs-devel@gnu.org; Thu, 06 Sep 2012 13:37:05 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:38631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9g0m-0002iI-Ct for emacs-devel@gnu.org; Thu, 06 Sep 2012 13:37:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FpYew/2dsb2JhbABEtBGBCIIVAQEEAScvIwULCw4mBwsUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="197719230" Original-Received: from 69-165-135-176.dsl.teksavvy.com (HELO pastel.home) ([69.165.135.176]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Sep 2012 13:37:03 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8264758B33; Thu, 6 Sep 2012 13:37:03 -0400 (EDT) In-Reply-To: <5048D826.3040103@yandex.ru> (Dmitry Antipov's message of "Thu, 06 Sep 2012 21:06:46 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153124 Archived-At: >> In 99% of the cases, it's easy to distinguish: one can be GC'd and the >> other can't. > From GC's point of view; if you look at window pointer and W->hchild, > W-> vchild and W->buffer are all Qnil, you still don't know whether W > is recorded in some window configuration object. If you're looking at W, that means there's a reference to it, and assuming that window is deleted, I say there's a 99% chance that the reference to it comes from a window-config. > Hm... it was definitely wrong for the windows because deleted window > may be "a little more alive" than deleted buffer or frame; but I still think > that treating "deleted/killed" object as "dead enough to not > look inside too much" is good enough for the rest. Let's do it field-by-field (and by setting to field to NULL/nil, which is a safer way to get the same result) rather than in one big jump into the unknown. Stefan