unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, theophilusx@gmail.com, emacs-devel@gnu.org
Subject: Re: extraclean and admin/grammars [was Re: Git master head build failure?]
Date: Thu, 01 Apr 2021 13:15:56 -0400	[thread overview]
Message-ID: <jwvzgyi3rov.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <p8k0pmq9bu.fsf_-_@fencepost.gnu.org> (Glenn Morris's message of "Thu, 01 Apr 2021 12:05:25 -0400")

> Emacs use of extraclean is really an abuse - see comments in the
> top-level Makefile. IIRC, the only differences between extraclean
> and bootstrap-clean are:

From a theoretical standpoint, I think `bootstrap-clean` should delete the
files that are both:
A) generated.
B) not faithfully described by the makefile dependencies.

In practice, very few of our generated files have 100% of their
dependencies  faithfully described in our makefiles, so the theory needs
to be taken with a large grain of salt.

Others less theoretical and more pragmatic factors that can be important are
C) used during the generation of other files.
D) changes frequently.

(C) can be important because it can cause not just errors down the line
when using the corresponding functionality, but also errors during the
build itself.

> 1) bootstrap-clean does not delete the generated leim files.
> This is because they are slow to rebuild and the sources rarely change.

AFAIK these don't satisfy B very much, (nor C nor D) so I don't see much
need to delete them in `bootstrap-clean`, indeed.

> 2) bootstrap-clean does not delete the generated semantic grammars.
> These are not slow to rebuild.  As my comment in
> admin/grammars/Makefile.in says, these could easily be deleted in
> bootstrap-clean.  I don't even really remember why I did it that
> way now.

I think for those we could also improve the makefile dependencies.

E.g. a first step could be to move `grammar-wy.el` to `grm-wy-boot.el` like we
do with `ldefs-boot.el` (see patch below) to break the
circular dependency.
WDYT?


        Stefan




  parent reply	other threads:[~2021-04-01 17:15 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  2:41 Git master head build failure? Tim Cross
2021-04-01  3:04 ` Stefan Monnier
2021-04-01  3:10   ` Tim Cross
2021-04-01  7:33     ` Eli Zaretskii
2021-04-01  8:57       ` Tim Cross
2021-04-01  9:17         ` tomas
2021-04-01  9:56       ` Daniel Brooks
2021-04-01  9:36     ` Gregor Zattler
2021-04-01 10:11       ` Andreas Schwab
2021-04-01  7:25   ` Eli Zaretskii
2021-04-01  8:34     ` Tim Cross
2021-04-01  9:00       ` Eli Zaretskii
2021-04-01 10:56         ` Stefan Kangas
2021-04-01 13:03           ` Eli Zaretskii
2021-04-01 13:32             ` Stefan Kangas
2021-04-01 13:02         ` Eli Zaretskii
2021-04-01 13:01     ` Eli Zaretskii
2021-04-01 13:03     ` Stefan Monnier
2021-04-01 13:07       ` Eli Zaretskii
2021-04-01 13:32         ` Stefan Kangas
2021-04-01 13:36           ` Eli Zaretskii
2021-04-01 15:32         ` Stefan Monnier
2021-04-01 15:37           ` Eli Zaretskii
2021-04-01 16:05             ` extraclean and admin/grammars [was Re: Git master head build failure?] Glenn Morris
2021-04-01 16:09               ` Lars Ingebrigtsen
2021-04-01 16:19                 ` Lars Ingebrigtsen
2021-04-02  4:19                   ` Tim Cross
2021-04-02  5:58                     ` Eli Zaretskii
2021-04-02 13:41                       ` Lars Ingebrigtsen
2021-04-02 13:58                         ` Eli Zaretskii
2021-04-01 18:31                 ` Eli Zaretskii
2021-04-02 13:40                   ` Lars Ingebrigtsen
2021-04-02 13:57                     ` Eli Zaretskii
2021-04-03 13:30                       ` Lars Ingebrigtsen
2021-04-03 14:15                         ` Eli Zaretskii
2021-04-03 22:36                           ` chad
2021-04-04  7:20                             ` Eli Zaretskii
2021-04-03 23:52                           ` Tim Cross
2021-04-04  7:39                             ` Eli Zaretskii
2021-04-04 19:44                           ` Lars Ingebrigtsen
2021-04-01 17:15               ` Stefan Monnier [this message]
2021-04-01 19:56                 ` Eli Zaretskii
2021-04-01 20:13                   ` Stefan Monnier
2021-04-03  7:58                     ` Eli Zaretskii
2021-04-13  2:20                       ` Stefan Monnier
2021-04-13 11:51                         ` Eli Zaretskii
2021-04-13 12:19                           ` Eli Zaretskii
2021-04-13 13:01                             ` Stefan Monnier
2021-04-13 12:59                           ` Stefan Monnier
2021-04-13 14:03                             ` Eli Zaretskii
2021-04-01 18:29               ` Eli Zaretskii
2021-04-04 16:28               ` Glenn Morris
2021-04-04 17:12                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzgyi3rov.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    --cc=theophilusx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).