unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Brooks <db48x@db48x.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tim Cross <theophilusx@gmail.com>,
	monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Git master head build failure?
Date: Thu, 01 Apr 2021 02:56:27 -0700	[thread overview]
Message-ID: <87r1ju9vlg.fsf@db48x.net> (raw)
In-Reply-To: <83lfa2h327.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Apr 2021 10:33:20 +0300")

Eli Zaretskii <eliz@gnu.org> writes:
> And second, we should simply make sure extraclean removes all the
> generated files, as documented, and keep it that way.  Looking into
> .gitignore means either building its interpreter into our build system
> (a non-trivial job, AFAIU), or using Git itself to do the job, which
> would mean the job cannot be done without Git -- a disadvantage, IMO.

There are external libraries that implement it, if anyone wants an
alternative or an inspiration. One example that I know of is the
MIT–licensed Rust crate “ignore”
(https://docs.rs/ignore/0.4.17/ignore/), but note that it only gives you
the files that aren’t ignored rather than all the ones that are.

It’s not all that complicated. In the end it boils down to repeated
application of a 30–line function, plus some parsing of course.
(https://docs.rs/globset/0.4.6/src/globset/glob.rs.html#159-186)

I would say that depending on Git for this doesn’t seem like too big of
a burden; anyone without git will be no worse off than before. Just
print a warning that mentions “git clean” and suggests installing git or
doing it by hand.

db48x



  parent reply	other threads:[~2021-04-01  9:56 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  2:41 Git master head build failure? Tim Cross
2021-04-01  3:04 ` Stefan Monnier
2021-04-01  3:10   ` Tim Cross
2021-04-01  7:33     ` Eli Zaretskii
2021-04-01  8:57       ` Tim Cross
2021-04-01  9:17         ` tomas
2021-04-01  9:56       ` Daniel Brooks [this message]
2021-04-01  9:36     ` Gregor Zattler
2021-04-01 10:11       ` Andreas Schwab
2021-04-01  7:25   ` Eli Zaretskii
2021-04-01  8:34     ` Tim Cross
2021-04-01  9:00       ` Eli Zaretskii
2021-04-01 10:56         ` Stefan Kangas
2021-04-01 13:03           ` Eli Zaretskii
2021-04-01 13:32             ` Stefan Kangas
2021-04-01 13:02         ` Eli Zaretskii
2021-04-01 13:01     ` Eli Zaretskii
2021-04-01 13:03     ` Stefan Monnier
2021-04-01 13:07       ` Eli Zaretskii
2021-04-01 13:32         ` Stefan Kangas
2021-04-01 13:36           ` Eli Zaretskii
2021-04-01 15:32         ` Stefan Monnier
2021-04-01 15:37           ` Eli Zaretskii
2021-04-01 16:05             ` extraclean and admin/grammars [was Re: Git master head build failure?] Glenn Morris
2021-04-01 16:09               ` Lars Ingebrigtsen
2021-04-01 16:19                 ` Lars Ingebrigtsen
2021-04-02  4:19                   ` Tim Cross
2021-04-02  5:58                     ` Eli Zaretskii
2021-04-02 13:41                       ` Lars Ingebrigtsen
2021-04-02 13:58                         ` Eli Zaretskii
2021-04-01 18:31                 ` Eli Zaretskii
2021-04-02 13:40                   ` Lars Ingebrigtsen
2021-04-02 13:57                     ` Eli Zaretskii
2021-04-03 13:30                       ` Lars Ingebrigtsen
2021-04-03 14:15                         ` Eli Zaretskii
2021-04-03 22:36                           ` chad
2021-04-04  7:20                             ` Eli Zaretskii
2021-04-03 23:52                           ` Tim Cross
2021-04-04  7:39                             ` Eli Zaretskii
2021-04-04 19:44                           ` Lars Ingebrigtsen
2021-04-01 17:15               ` Stefan Monnier
2021-04-01 19:56                 ` Eli Zaretskii
2021-04-01 20:13                   ` Stefan Monnier
2021-04-03  7:58                     ` Eli Zaretskii
2021-04-13  2:20                       ` Stefan Monnier
2021-04-13 11:51                         ` Eli Zaretskii
2021-04-13 12:19                           ` Eli Zaretskii
2021-04-13 13:01                             ` Stefan Monnier
2021-04-13 12:59                           ` Stefan Monnier
2021-04-13 14:03                             ` Eli Zaretskii
2021-04-01 18:29               ` Eli Zaretskii
2021-04-04 16:28               ` Glenn Morris
2021-04-04 17:12                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1ju9vlg.fsf@db48x.net \
    --to=db48x@db48x.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=theophilusx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).