From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michal Nazarewicz <mpn@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] textmodes/flyspell.el (flyspell-post-command-hook): Decided whether to check previous word while in correct buffer.
Date: Tue, 26 Mar 2013 21:09:39 -0400 [thread overview]
Message-ID: <jwvy5d9fy47.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <ed66319a42c3c8e4ab3f4041ec0b78b26461529c.1364320939.git.mina86@mina86.com> (Michal Nazarewicz's message of "Tue, 26 Mar 2013 19:09:05 +0100")
> If command changed the buffer, the decision may be made based on the
> current buffer even though it should based on the previous one. This
> may lead to false positives and more importantly to errors since
> `flyspell-pre-point' is buffer local so it may have unsanitised value
> (such as nil) in previous buffer.
Can't we just say that if current-buffer is different from the previous
one, then don't do anything?
Stefan
next prev parent reply other threads:[~2013-03-27 1:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 18:09 [PATCH] textmodes/flyspell.el (flyspell-post-command-hook): Decided whether to check previous word while in correct buffer Michal Nazarewicz
2013-03-27 1:09 ` Stefan Monnier [this message]
2013-03-27 12:47 ` [PATCHv2] textmodes/flyspell.el: Don't check pre-word if buffer was switched Michal Nazarewicz
2013-04-20 4:53 ` Agustin Martin
2013-04-20 15:46 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy5d9fy47.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mpn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).