From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] textmodes/flyspell.el (flyspell-post-command-hook): Decided whether to check previous word while in correct buffer. Date: Tue, 26 Mar 2013 21:09:39 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364346590 315 80.91.229.3 (27 Mar 2013 01:09:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Mar 2013 01:09:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michal Nazarewicz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 27 02:10:16 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UKesT-0002Xg-Ee for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2013 02:10:09 +0100 Original-Received: from localhost ([::1]:36843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKes5-0003Yk-FA for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2013 21:09:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKes1-0003YS-MQ for emacs-devel@gnu.org; Tue, 26 Mar 2013 21:09:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKes0-0005ZR-PF for emacs-devel@gnu.org; Tue, 26 Mar 2013 21:09:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:28878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKes0-0005ZL-Kz for emacs-devel@gnu.org; Tue, 26 Mar 2013 21:09:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgaxH5AOkQoDpHqBXoMT X-IPAS-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgaxH5AOkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="5874021" Original-Received: from 69-196-180-174.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Mar 2013 21:09:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 969AE63361; Tue, 26 Mar 2013 21:09:39 -0400 (EDT) In-Reply-To: (Michal Nazarewicz's message of "Tue, 26 Mar 2013 19:09:05 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158254 Archived-At: > If command changed the buffer, the decision may be made based on the > current buffer even though it should based on the previous one. This > may lead to false positives and more importantly to errors since > `flyspell-pre-point' is buffer local so it may have unsanitised value > (such as nil) in previous buffer. Can't we just say that if current-buffer is different from the previous one, then don't do anything? Stefan