unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: Cleaning up code
Date: Thu, 15 Aug 2013 10:37:27 -0400	[thread overview]
Message-ID: <jwvy583f2cn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87mwojiby1.fsf@gmx.de> (Michael Albinus's message of "Thu, 15 Aug 2013 10:40:38 +0200")

> There is also another case where it doesn't work as expected. Often, I
> let bind a variable for side effect, like this:

>       (let ((default-directory (tramp-compat-temporary-file-directory))
>             (outline-regexp tramp-debug-outline-regexp))
>         (outline-mode))

> And I get from the byte compiler

> tramp.el:1400:1:Warning: Unused lexical variable `outline-regexp'

That is a correct warning, telling you that it treated outline-regexp as
a lexical variable and hence that it did not generate the code you want.
IOW you need to add

   (defvar outline-regexp)


-- Stefan



  reply	other threads:[~2013-08-15 14:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 15:57 Cleaning up code Stefan Monnier
2013-08-13 15:17 ` Michael Albinus
2013-08-13 16:30   ` Stefan Monnier
2013-08-15  8:40     ` Michael Albinus
2013-08-15 14:37       ` Stefan Monnier [this message]
2013-08-15 17:05         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy583f2cn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).