unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: Cleaning up code
Date: Tue, 13 Aug 2013 12:30:47 -0400	[thread overview]
Message-ID: <jwvd2phimkh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87eh9x62o1.fsf@gmx.de> (Michael Albinus's message of "Tue, 13 Aug 2013 17:17:18 +0200")

> However, setting `byte-compile-force-lexical-warnings' to t is too
> coarse. For example, Tramp's macro `with-parsed-tramp-file-name'
> let-binds several variables "just in case". They are reported as unused
> then, on every invocation of that macro.

Yup, that's one of the main problems: when a single let in the source
ends up duplicated after expansion so some expansions may use it while
others end up not using it.

We need to add some way to tell Emacs that it should check "the sum of
all uses" or something like that.  In your case, this "sum" is
open-ended, so we should instead just tell it not to check at all.


        Stefan



  reply	other threads:[~2013-08-13 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 15:57 Cleaning up code Stefan Monnier
2013-08-13 15:17 ` Michael Albinus
2013-08-13 16:30   ` Stefan Monnier [this message]
2013-08-15  8:40     ` Michael Albinus
2013-08-15 14:37       ` Stefan Monnier
2013-08-15 17:05         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd2phimkh.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).