Re: [Emacs-diffs] emacs-25 b99141d: Make erc completion case-insensitive again

Re: [Emacs-diffs] emacs-25 b99141d: Make erc completion case-insensitive again

[Stefan Monnier]

> +(defun erc-completion-at-point ()
> +  "Perform complection on the text around point case-insentitively.
> +See `completion-at-point'."
> +  (interactive)
> +  (let ((completion-ignore-case t))
> +    (completion-at-point)))

If the elements in the completion table are indeed case-insensitive,
then the right way to do that is to set the
completion-table accordingly.

E.g. replace

     <completion-table>

with

     (lambda (s p a)
       (let ((completion-ignore-case t))
         (complete-with-action a <completion-table> s p)))


-- Stefan

Re: [Emacs-diffs] emacs-25 b99141d: Make erc completion case-insensitive again

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> If the elements in the completion table are indeed case-insensitive,
> then the right way to do that is to set the
> completion-table accordingly.
>
> E.g. replace
>
>      <completion-table>
>
> with
>
>      (lambda (s p a)
>        (let ((completion-ignore-case t))
>          (complete-with-action a <completion-table> s p)))

Hm...  If I do the following in pcomplete-completions-at-point

-          (list beg (point) table
+          (list beg (point)
+                (lambda (s p a)
+                  (let ((completion-ignore-case t))
+                    (complete-with-action a table s p)))

it still doesn't give me case-insensitive completion...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] emacs-25 b99141d: Make erc completion case-insensitive again

[Stefan Monnier]

> Hm...  If I do the following in pcomplete-completions-at-point
>
> -          (list beg (point) table
> +          (list beg (point)
> +                (lambda (s p a)
> +                  (let ((completion-ignore-case t))
> +                    (complete-with-action a table s p)))
>
> it still doesn't give me case-insensitive completion...

Hmm... so we have a problem.  BTW, you don't need the above, you can
just do the following for a test:

          (when t;;pcomplete-ignore-case
            (setq table (completion-table-case-fold table)))

Or alternatively set pcomplete-ignore-case to t.  And indeed, in my test
it did not make the completion case-sensitive.

But fixing it with a new command isn't right, because
completion-at-point is called from various places.

It looks like the core of the problem is that completion-table-case-fold
doesn't work.

For the emacs-25 branch, the better fix is probably to set
completion-ignore-case to t buffer-locally in ERC's major mode.


        Stefan

Re: [Emacs-diffs] emacs-25 b99141d: Make erc completion case-insensitive again

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> For the emacs-25 branch, the better fix is probably to set
> completion-ignore-case to t buffer-locally in ERC's major mode.

I've now done so and removed the specialised erc completion command.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no