From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Small fix in `shell--unquote&requote-argument' - please review
Date: Wed, 31 Aug 2016 09:27:54 -0400 [thread overview]
Message-ID: <jwvwpixoysc.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: m2zinthmbf.fsf@fastmail.fm
> 1. match is always less than (length str), so I guess they meant
> `((< (1+ match) (length qstr))'.
> 2. If `string-match' searching for ending single quote failed,
> `(match-string 0)' is still called - be careful not to do this.
Do you have corresponding recipes to trigger the corresponding errors
(so we could write tests)? This part of my code is in dire need of
tests, otherwise it's much too easy to introduce regressions.
Stefan
next prev parent reply other threads:[~2016-08-31 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 23:24 Small fix in `shell--unquote&requote-argument' - please review Filipp Gunbin
2016-08-31 13:27 ` Stefan Monnier [this message]
2016-09-01 13:15 ` Filipp Gunbin
2016-09-01 13:39 ` Stefan Monnier
2016-09-01 14:35 ` Filipp Gunbin
2016-09-08 19:22 ` Filipp Gunbin
2016-09-08 20:23 ` Stefan Monnier
2016-10-26 18:32 ` Stefan Monnier
2016-10-27 12:41 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwpixoysc.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).