From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Filipp Gunbin <fgunbin@fastmail.fm>
Cc: emacs-devel@gnu.org
Subject: Re: Small fix in `shell--unquote&requote-argument' - please review
Date: Thu, 08 Sep 2016 16:23:22 -0400 [thread overview]
Message-ID: <jwv1t0u5ehd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2d1keurgy.fsf@fgunbin.local> (Filipp Gunbin's message of "Thu, 08 Sep 2016 22:22:21 +0300")
> 1. (shell--unquote&requote-argument "te'st" 2)
>
> This produces `("testst" 2 comint-quote-filename)'.
>
> Having found first `'', `string-match' cannot find closing quote.
> Then (match-end 0) is used, it's value is "undefined", but happens to
> be 3, so we duplicate last 2 chars and that's wrong.
>
> 2. (shell--unquote&requote-argument "test'" 2)
>
> This produces `("test" 2 comint-quote-filename)'.
>
> First `'' happens to be at the end of line. The condition
>
> `(< match (1+ (length qstr)))'
OK, great, that looks very helpful.
I'll take a look at the patch ASAP,
Stefan
next prev parent reply other threads:[~2016-09-08 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 23:24 Small fix in `shell--unquote&requote-argument' - please review Filipp Gunbin
2016-08-31 13:27 ` Stefan Monnier
2016-09-01 13:15 ` Filipp Gunbin
2016-09-01 13:39 ` Stefan Monnier
2016-09-01 14:35 ` Filipp Gunbin
2016-09-08 19:22 ` Filipp Gunbin
2016-09-08 20:23 ` Stefan Monnier [this message]
2016-10-26 18:32 ` Stefan Monnier
2016-10-27 12:41 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1t0u5ehd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=fgunbin@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).