From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Pixel scrolling support
Date: Thu, 25 Nov 2021 21:26:41 -0500 [thread overview]
Message-ID: <jwvwnkvmzbi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a6hrzrcv.fsf@yahoo.com> (Po Lu's message of "Fri, 26 Nov 2021 08:35:12 +0800")
Po Lu [2021-11-26 08:35:12] wrote:
> I would like to install the following file:
Looks OK to me, tho I wonder why you'd want to use a separate file
rather than add this directly in `mwheel.el`.
Also, see a few more comments below.
Stefan
> (defvar better-pixel-scroll-mode-map (make-sparse-keymap)
> "The key map used by `better-pixel-scroll-mode'.")
>
> (define-key better-pixel-scroll-mode-map [wheel-down] #'better-pixel-scroll)
> (define-key better-pixel-scroll-mode-map [wheel-up] #'better-pixel-scroll)
Please combine this into
(defvar better-pixel-scroll-mode-map
(let ((map (make-sparse-keymap)))
(define-key map [wheel-down] #'better-pixel-scroll)
(define-key map [wheel-up] #'better-pixel-scroll)
map)
"The key map used by `better-pixel-scroll-mode'.")
Or better yet use `defvar-keymap`.
> ;;;###autoload
> (define-minor-mode better-pixel-scroll-mode
> "Toggle pixel scrolling.
> When enabled, this minor mode allows to scroll the display
> precisely, according to the turning of the mouse wheel."
> :global t
> :group 'mouse
> :keymap better-pixel-scroll-mode-map
> (setq x-coalesce-scroll-events
> (not better-pixel-scroll-mode)))
The `:keymap` arg is redundant.
next prev parent reply other threads:[~2021-11-26 2:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a6hrzrcv.fsf.ref@yahoo.com>
2021-11-26 0:35 ` Pixel scrolling support Po Lu
2021-11-26 2:26 ` Stefan Monnier [this message]
2021-11-26 3:06 ` Po Lu
2021-11-26 3:12 ` Po Lu
2021-11-26 6:41 ` Eli Zaretskii
2021-11-26 6:40 ` Eli Zaretskii
2021-11-26 6:45 ` Po Lu
2021-11-26 6:58 ` Eli Zaretskii
2021-11-26 7:01 ` Po Lu
2021-11-26 8:35 ` Eli Zaretskii
2021-11-26 9:29 ` Po Lu
2021-11-26 11:26 ` Eli Zaretskii
2021-11-26 11:38 ` Po Lu
2021-11-26 12:00 ` Eli Zaretskii
2021-11-26 12:09 ` Po Lu
2021-11-26 12:42 ` Eli Zaretskii
2021-11-26 12:46 ` Po Lu
2021-11-26 12:49 ` Po Lu
2021-11-26 13:00 ` Eli Zaretskii
2021-11-26 13:03 ` Po Lu
2021-11-26 12:07 ` Stephen Berman
2021-11-26 13:35 ` Stefan Monnier
2021-11-26 13:41 ` Po Lu
2021-11-26 13:46 ` Eli Zaretskii
2021-11-26 13:50 ` Po Lu
2021-11-26 5:57 ` Aaron Madlon-Kay
2021-11-26 6:00 ` Po Lu
2021-11-26 6:11 ` Aaron Madlon-Kay
2021-11-26 6:22 ` Jim Porter
2021-11-26 6:30 ` Po Lu
2021-11-26 6:33 ` Eli Zaretskii
2022-05-18 2:53 ` Michael Heerdegen
2022-05-18 3:11 ` Po Lu
2022-05-18 3:27 ` pixel scroll vs. osm (was: Pixel scrolling support) Michael Heerdegen
2022-05-18 3:47 ` pixel scroll vs. osm Po Lu
2022-05-19 0:34 ` Michael Heerdegen
2022-05-21 0:18 ` Michael Heerdegen
2022-05-21 1:34 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwnkvmzbi.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).