From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Pixel scrolling support Date: Thu, 25 Nov 2021 21:26:41 -0500 Message-ID: References: <87a6hrzrcv.fsf.ref@yahoo.com> <87a6hrzrcv.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 26 03:28:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqQyX-0004f0-7U for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Nov 2021 03:28:33 +0100 Original-Received: from localhost ([::1]:59448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqQyV-0005LA-R4 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 21:28:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqQwr-0003Qz-QC for emacs-devel@gnu.org; Thu, 25 Nov 2021 21:26:50 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqQwo-0000wK-Uw for emacs-devel@gnu.org; Thu, 25 Nov 2021 21:26:49 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B752A10025F; Thu, 25 Nov 2021 21:26:44 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0227C100040; Thu, 25 Nov 2021 21:26:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1637893603; bh=FWQLGw27kSLsUtkhitFR3uFuuzeLAw5dr7qltfu408E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MFVrtf4Ss+ml3ITwnfLT8FkB8RD5emVedDm+V3pr8xAN80Dt2qmV8hRySKNYgjL9N qoc5as4r/opoAVM/D+elNYKfMgxH0pMbH4Hh6BZddstBPcw/SomEFYykx6jYoJF3Bp EvFKFqlbL41ZQzYDMOit0BqQ9P6nUTDChXi+qKAr33ZUZAn0US8hrnr2qa6xcQX6FF RSXqM3Om6fXTnobHAfb6GwKyANqKNeLc8dDj1h/nGCmRkV4DAgt9tWPqYqDOQjOQW2 ZQ/YRLQF763zoKAPGjat0HWXRhzhXM0MKyCqbHRsLR3pINvYxFLcEOTK8/nYqV3K7H 2omsWe3u6O6Xg== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CD44E120B02; Thu, 25 Nov 2021 21:26:42 -0500 (EST) In-Reply-To: <87a6hrzrcv.fsf@yahoo.com> (Po Lu's message of "Fri, 26 Nov 2021 08:35:12 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280187 Archived-At: Po Lu [2021-11-26 08:35:12] wrote: > I would like to install the following file: Looks OK to me, tho I wonder why you'd want to use a separate file rather than add this directly in `mwheel.el`. Also, see a few more comments below. Stefan > (defvar better-pixel-scroll-mode-map (make-sparse-keymap) > "The key map used by `better-pixel-scroll-mode'.") > > (define-key better-pixel-scroll-mode-map [wheel-down] #'better-pixel-scroll) > (define-key better-pixel-scroll-mode-map [wheel-up] #'better-pixel-scroll) Please combine this into (defvar better-pixel-scroll-mode-map (let ((map (make-sparse-keymap))) (define-key map [wheel-down] #'better-pixel-scroll) (define-key map [wheel-up] #'better-pixel-scroll) map) "The key map used by `better-pixel-scroll-mode'.") Or better yet use `defvar-keymap`. > ;;;###autoload > (define-minor-mode better-pixel-scroll-mode > "Toggle pixel scrolling. > When enabled, this minor mode allows to scroll the display > precisely, according to the turning of the mouse wheel." > :global t > :group 'mouse > :keymap better-pixel-scroll-mode-map > (setq x-coalesce-scroll-events > (not better-pixel-scroll-mode))) The `:keymap` arg is redundant.