[PATCH] json-encode-char bug?

[PATCH] json-encode-char bug?

[Takafumi Arakaki]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Dear Emacs devs,

I am using json.el for my IPython notebook client in Emacs [1].
json.el works very well but I think I found a bug.  It prints
character 161 (Non-breaking space) as a raw character, but it causes
error when parsing it in Python.  I think it should be escaped in
\uNNNN form.  I attached a patch to fix this problem.

[1] https://github.com/tkf/emacs-ipython-notebook


Best,
Takafumi Arakaki

[-- Attachment #2: json.patch --]
[-- Type: application/octet-stream, Size: 427 bytes --]

diff --git a/lisp/json.el b/lisp/json.el
index f1ee3a5..7d1c96a 100644
--- a/lisp/json.el
+++ b/lisp/json.el
@@ -315,7 +315,7 @@ representation will be parsed correctly."
      (control-char
       (format "\\%c" control-char))
      ;; ASCIIish printable character
-     ((and (> char 31) (< char 161))
+     ((and (> char 31) (< char 160))
       (format "%c" char))
      ;; Fallback: UCS code point in \uNNNN form
      (t

Re: [PATCH] json-encode-char bug?

[Stefan Monnier]

> json.el works very well but I think I found a bug.  It prints
> character 161 (Non-breaking space) as a raw character, but it causes

NBSP is actually 160, but I see what you mean.

>       ;; ASCIIish printable character
> -     ((and (> char 31) (< char 161))
> +     ((and (> char 31) (< char 160))

Actually, ASCII only goes up to 127, so I've changed the 161 to 128
(now that I think about it, ASCII 127 is DEL which isn't very printable
either so maybe I should have replaced it with 127).


        Stefan

Re: [PATCH] json-encode-char bug?

[Takafumi Arakaki]

On Thu, Sep 27, 2012 at 3:13 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> Actually, ASCII only goes up to 127, so I've changed the 161 to 128
> (now that I think about it, ASCII 127 is DEL which isn't very printable
> either so maybe I should have replaced it with 127).

Thank you very much for the quick fix.  Indeed,
json.dumps(unichr(127)) returns '"\\u007f"' in Python, so I guess it's
better to change 128 to 127.

In browser, JSON.stringify(String.fromCharCode(127)) returns '""',
which is raw code I guess.  But
JSON.stringify(String.fromCharCode(160)) returns '" "', so maybe this
is my JS console's problem (node and google chrome) or they are
encoded at different stage.

Takafumi

PS: Sorry to send it twice to you, Stefan.  I meant to sent it to emacs-devel.

Re: [PATCH] json-encode-char bug?

[Stefan Monnier]

> Thank you very much for the quick fix.  Indeed,
> json.dumps(unichr(127)) returns '"\\u007f"' in Python, so I guess it's
> better to change 128 to 127.

Thanks, done,


        Stefan