From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Proposed changes to text-mode.el
Date: Tue, 26 Mar 2019 09:00:34 -0400 [thread overview]
Message-ID: <jwvva053i7o.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 87o95yxvtt.fsf@tcd.ie
> I attach three patches for lisp/textmodes/text-mode.el arising from the
> discussion in bug#34671.
>
> The first enables lexical-binding and makes some minor simplifications.
>
> The second makes text-mode no longer reset indent-line-function to
> indent-relative locally, a change (info "(elisp) Example Major Modes")
> has been promising for many moons. AFAICT, text-mode works even when
> indent-line-function is not set to indent-relative (as I'd hope). I've
> had a quick look through all the modes derived from text-mode in
> emacs.git and nothing strikes me as an obvious incompatibility with the
> proposed change. Are there any significant reasons to keep the current
> setting of indent-line-function in text-mode?
The reason why I kept the `setq-local` when I changed the default to
`indent-relative` was simply to be conservative.
> The third obsoletes the variable text-mode-variant, which is unused in
> both emacs.git and elpa.git, and has been recommending derived-mode-p as
> a better alternative in its docstring for almost two decades.
> WDYT?
LGTM,
Stefan
next prev parent reply other threads:[~2019-03-26 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 1:34 Proposed changes to text-mode.el Basil L. Contovounesios
2019-03-26 13:00 ` Stefan Monnier [this message]
2019-03-27 3:50 ` Basil L. Contovounesios
2019-03-27 15:44 ` Eli Zaretskii
2019-03-31 21:42 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvva053i7o.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).