From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to text-mode.el Date: Tue, 26 Mar 2019 09:00:34 -0400 Message-ID: References: <87o95yxvtt.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="87579"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 26 14:03:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8lk5-000MZ6-Tz for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2019 14:03:50 +0100 Original-Received: from localhost ([127.0.0.1]:59618 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8lk4-0002K2-QP for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2019 09:03:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8lhC-0001Df-IQ for emacs-devel@gnu.org; Tue, 26 Mar 2019 09:00:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8lhB-0004mh-Js for emacs-devel@gnu.org; Tue, 26 Mar 2019 09:00:50 -0400 Original-Received: from [195.159.176.226] (port=54876 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8lhB-0004mC-AP for emacs-devel@gnu.org; Tue, 26 Mar 2019 09:00:49 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h8lhA-000J9n-0H for emacs-devel@gnu.org; Tue, 26 Mar 2019 14:00:48 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:WnN0lkl7z7riE2fOaodFdn/biu8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234741 Archived-At: > I attach three patches for lisp/textmodes/text-mode.el arising from the > discussion in bug#34671. > > The first enables lexical-binding and makes some minor simplifications. > > The second makes text-mode no longer reset indent-line-function to > indent-relative locally, a change (info "(elisp) Example Major Modes") > has been promising for many moons. AFAICT, text-mode works even when > indent-line-function is not set to indent-relative (as I'd hope). I've > had a quick look through all the modes derived from text-mode in > emacs.git and nothing strikes me as an obvious incompatibility with the > proposed change. Are there any significant reasons to keep the current > setting of indent-line-function in text-mode? The reason why I kept the `setq-local` when I changed the default to `indent-relative` was simply to be conservative. > The third obsoletes the variable text-mode-variant, which is unused in > both emacs.git and elpa.git, and has been recommending derived-mode-p as > a better alternative in its docstring for almost two decades. > WDYT? LGTM, Stefan