unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master df49910: Create a buffer-local binding to improve performance
       [not found] ` <20200528233610.4778120A2C@vcs0.savannah.gnu.org>
@ 2020-05-29  4:34   ` Stefan Monnier
  0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2020-05-29  4:34 UTC (permalink / raw)
  To: emacs-devel

> +  (with-temp-buffer
> +    ;; Each call to ido-ignore-item-p LET-binds case-fold-search.
> +    ;; That is slow if there's no buffer-local binding available,
> +    ;; roughly O(number of buffers).  This hack avoids it.

Hmm... why is it implemented as a DEFVAR_PER_BUFFER?
I think an even better fix is to turn it into a normal DEFVAR_LISP
(together with a `make-variable-buffer-local`).  After all I suspect
that it's rather unusual to set it buffer-locally (it's almost always
let-bound instead).


        Stefan




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-29  4:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200528233608.22610.74304@vcs0.savannah.gnu.org>
     [not found] ` <20200528233610.4778120A2C@vcs0.savannah.gnu.org>
2020-05-29  4:34   ` master df49910: Create a buffer-local binding to improve performance Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).