* Re: [nongnu] elpa/xah-fly-keys 9637e144a0: - xah-copy-rectangle-to-kill-ring removed. use copy-rectangle-to-register.
[not found] ` <20231103020157.92C1AC0C186@vcs2.savannah.gnu.org>
@ 2023-11-03 2:33 ` Stefan Monnier
0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2023-11-03 2:33 UTC (permalink / raw)
To: Xah Lee; +Cc: emacs-devel
> - (interactive
> - (if (region-active-p)
> - (list (region-beginning) (region-end))
> - (list (line-beginning-position) (line-end-position))))
> + (interactive)
> + (let (xp1 xp2)
> + (if (and Begin End)
> + (setq xp1 Begin xp2 End)
> + (if (region-active-p)
> + (setq xp1 (region-beginning) xp2 (region-end))
> + (setq xp1 (line-beginning-position) xp2 (line-end-position))))
Hmm... in my book the old version above is more correct and the new
version is confusing interactive and non-interactive uses.
I understand that this is motivated by "now can be repeated by
repeat-complex-command".
I think I see why `repeat-complex-command` would work better with the
new code (and I suspect this deserves a bug report because it should be
possible to keep the code in the interactive form while making it work
well with `repeat-complex-command`), but I wonder in which circumstance
it would make sense to repeat `xah-unescape-quotes`?
Stefan
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-03 2:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <169897691731.12858.16884491183005943778@vcs2.savannah.gnu.org>
[not found] ` <20231103020157.92C1AC0C186@vcs2.savannah.gnu.org>
2023-11-03 2:33 ` [nongnu] elpa/xah-fly-keys 9637e144a0: - xah-copy-rectangle-to-kill-ring removed. use copy-rectangle-to-register Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).