Bogus temporary frame created by Gnus

Bogus temporary frame created by Gnus

[Stefan Monnier]

When I do "O f" in Gnus, I'm first prompted for a file name, and then a new
frame is created that displays a temporary buffer that's immediately killed.
I think it's just a bug, which is fixed by the patch below.

Any objection?

Note that several other gnus-summary-save-in-* functions may suffer from the
same problem, but I don't have the time/energy to check them,


        Stefan


PS: If you can't reproduce the problem, it's probably because your
    pop-up-frames and special-display-regexp settings are different
    from mine.


--- orig/lisp/gnus/gnus-art.el
+++ mod/lisp/gnus/gnus-art.el
@@ -3314,7 +3314,7 @@
 		  "Save %s in file:" filename
 		  gnus-file-save-name gnus-newsgroup-name
 		  gnus-current-headers 'gnus-newsgroup-last-file))
-  (gnus-eval-in-buffer-window gnus-save-article-buffer
+  (with-current-buffer gnus-save-article-buffer
     (save-excursion
       (save-restriction
 	(widen)

Re: Bogus temporary frame created by Gnus

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> When I do "O f" in Gnus, I'm first prompted for a file name, and then a new
> frame is created that displays a temporary buffer that's immediately killed.
> I think it's just a bug, which is fixed by the patch below.
>
> Any objection?
>
> Note that several other gnus-summary-save-in-* functions may suffer from the
> same problem, but I don't have the time/energy to check them,

I've now changed the instances in this area I noticed...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen