unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Luke Lee <luke.yx.lee@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Please don't obsolete "crisp.el"
Date: Thu, 10 Jul 2014 09:48:30 -0400	[thread overview]
Message-ID: <jwvtx6pnxrd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAA=xLRObgHrweb9_+RNm3D27b9dG-CfpBnKXwwQsK9+-bU2XJQ@mail.gmail.com> (Luke Lee's message of "Thu, 10 Jul 2014 10:43:19 +0800")

>>>> ELPA with Emacs crisp.el merged >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

> commit 8739586a2539b482bdb48350bbcda00c44d82805
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date:   Mon Jul 7 09:17:28 2014 -0400

>     * caps-lock: New package.

> +commit 086a393b7aae6fbe214839aea67a02133f5ef955
> +>Author: Glenn Morris <rgm@gnu.org>
> +Date:   Sun Jul 6 16:58:52 2014 -0700
> +
> +    * cua-rect.el (cua--activate-rectangle): Avoid setting cua--rectangle
> ...

Hmm?? The above cua-rect.el commit did not touch crisp.el, so it seems
not just annoying but incorrect for it to be there.  It points to
a problem in the way crisp.el's changes are selected.

> 1. I found that in the Emacs repo git clone, A LOT OF commits did not even
>    touched crisp.el but are all included in the log history of
>    crisp.el.  I don't know if it's caused by bzr -> git mirroring
>    information loss, or if this happend even in earlier years before
>    bzr is used, or if there are some defetcts during git
>    filter-branch.  This seems to leave quite a few dummy commits
>    without any diff against crisp.el.

"bzr log -n 0 lisp/obsolete/crisp.el| grep revno | wc"

gives me 77 "commits".  Looking at the entries, they all seem to be
somewhat related to crisp.el, so it looks like a problem on Git's side.

> 2. We merged only the commits that relates to "crisp.el".  But those commits
>    might not just crisp.el specific and touched other files too.
>    You will still see the diff of other Emacs trunk files that never
>    exists in ELPA, when examine those commits in detail.

Yuck.

If the "extra spurious commits" or the "extra spurious files in commits"
are not too frequent (like 10% of the crisp.el history), it's not
too bad.  But if it's much more significant, then we're better off
without the history (which is still available in Emacs's repository
anyway).


        Stefan



  parent reply	other threads:[~2014-07-10 13:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07  9:13 Please don't obsolete "crisp.el" Luke Lee
2014-07-07 15:58 ` Glenn Morris
2014-07-07 16:36   ` Stefan Monnier
2014-07-08  5:01     ` Luke Lee
2014-07-08 18:42       ` Glenn Morris
2014-07-08 20:04         ` Stefan Monnier
2014-07-09  6:47           ` Luke Lee
2014-07-09 10:39             ` Luke Lee
2014-07-09 13:24             ` Stefan Monnier
2014-07-10  2:43               ` Luke Lee
2014-07-10  6:20                 ` Luke Lee
2014-07-10 13:48                 ` Stefan Monnier [this message]
2014-07-10 14:26                 ` Stefan Monnier
2014-07-11 10:03                   ` Luke Lee
2014-07-11 10:32                     ` Yuri Khan
2014-07-14 10:28                       ` Luke Lee
2014-07-11 12:44                     ` Andreas Schwab
2014-07-14 10:30                       ` Luke Lee
2014-07-11 13:32                     ` Stefan Monnier
2014-07-14 10:29                       ` Luke Lee
2014-07-21  2:26                         ` luke.yx.lee
2014-07-21  4:00                           ` Stefan Monnier
2014-07-12 14:47         ` Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtx6pnxrd.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=luke.yx.lee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).