From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Please don't obsolete "crisp.el" Date: Thu, 10 Jul 2014 09:48:30 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1405000138 29766 80.91.229.3 (10 Jul 2014 13:48:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jul 2014 13:48:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Luke Lee Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 10 15:48:50 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X5EiQ-00088H-2j for ged-emacs-devel@m.gmane.org; Thu, 10 Jul 2014 15:48:50 +0200 Original-Received: from localhost ([::1]:38149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5EiP-0008Fi-I8 for ged-emacs-devel@m.gmane.org; Thu, 10 Jul 2014 09:48:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5EiE-0008Eo-Mr for emacs-devel@gnu.org; Thu, 10 Jul 2014 09:48:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5Ei8-0004ln-Ax for emacs-devel@gnu.org; Thu, 10 Jul 2014 09:48:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:13678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5Ei8-0004lj-61; Thu, 10 Jul 2014 09:48:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBJy8jBQsLFCASFBgNJBOHcQjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBJy8jBQsLFCASFBgNJBOHcQjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77059923" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jul 2014 09:48:31 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C5F6B604AF; Thu, 10 Jul 2014 09:48:30 -0400 (EDT) In-Reply-To: (Luke Lee's message of "Thu, 10 Jul 2014 10:43:19 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172931 Archived-At: >>>> ELPA with Emacs crisp.el merged >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > commit 8739586a2539b482bdb48350bbcda00c44d82805 > Author: Stefan Monnier > Date: Mon Jul 7 09:17:28 2014 -0400 > * caps-lock: New package. > +commit 086a393b7aae6fbe214839aea67a02133f5ef955 > +>Author: Glenn Morris > +Date: Sun Jul 6 16:58:52 2014 -0700 > + > + * cua-rect.el (cua--activate-rectangle): Avoid setting cua--rectangle > ... Hmm?? The above cua-rect.el commit did not touch crisp.el, so it seems not just annoying but incorrect for it to be there. It points to a problem in the way crisp.el's changes are selected. > 1. I found that in the Emacs repo git clone, A LOT OF commits did not even > touched crisp.el but are all included in the log history of > crisp.el. I don't know if it's caused by bzr -> git mirroring > information loss, or if this happend even in earlier years before > bzr is used, or if there are some defetcts during git > filter-branch. This seems to leave quite a few dummy commits > without any diff against crisp.el. "bzr log -n 0 lisp/obsolete/crisp.el| grep revno | wc" gives me 77 "commits". Looking at the entries, they all seem to be somewhat related to crisp.el, so it looks like a problem on Git's side. > 2. We merged only the commits that relates to "crisp.el". But those commits > might not just crisp.el specific and touched other files too. > You will still see the diff of other Emacs trunk files that never > exists in ELPA, when examine those commits in detail. Yuck. If the "extra spurious commits" or the "extra spurious files in commits" are not too frequent (like 10% of the crisp.el history), it's not too bad. But if it's much more significant, then we're better off without the history (which is still available in Emacs's repository anyway). Stefan