From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
"Pip Cet" <pipcet@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Bug#38708: eq vs eql in byte-compiled code
Date: Sat, 04 Jan 2020 14:49:06 -0500 [thread overview]
Message-ID: <jwvtv5b80l3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <b432f28c-b126-1edb-231d-5ab3e1b171ab@cs.ucla.edu> (Paul Eggert's message of "Sat, 4 Jan 2020 11:33:02 -0800")
>>> * src/alloc.c (make_pure_bignum): Remove, as we can’t copy (much
>>> less purecopy) bignums any more.
>> Sounds dangerous: it means that pure objects which point to bignums
>> could end up with dangling pointers because the GC won't see those
>> pointers and will then GC the corresponding bignum.
>
> That dangerous thing can't happen, as the change causes purecopy to signal an
> error when given a bignum. That is, bignums fall into the same category as
> markers, overlays and other objects where purecopy signals an error. Since these
> objects are not used in the early phase of building that calls purecopy, this
> should not be an issue.
Ah, sorry, I missed that. It's OK then (and if/when we need to fix it,
then we'll want to do the move I mentioned).
Stefan
prev parent reply other threads:[~2020-01-04 19:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 15:07 Bug#38708: eq vs eql in byte-compiled code Pip Cet
2019-12-31 15:51 ` Andrea Corallo
2019-12-31 16:05 ` Mattias Engdegård
2019-12-31 17:38 ` Paul Eggert
2020-01-01 12:38 ` Mattias Engdegård
2020-01-02 8:38 ` Paul Eggert
2020-01-02 17:26 ` Mattias Engdegård
2020-01-04 19:55 ` Stefan Monnier
2020-01-22 10:56 ` Mattias Engdegård
2020-01-25 0:59 ` Paul Eggert
2020-01-01 15:45 ` Stefan Monnier
2020-01-02 7:52 ` Paul Eggert
2020-01-02 12:27 ` Pip Cet
2020-01-02 23:12 ` Paul Eggert
2020-01-02 13:48 ` Eli Zaretskii
2020-01-04 18:54 ` Stefan Monnier
2020-01-04 19:33 ` Paul Eggert
2020-01-04 19:49 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtv5b80l3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).