From: Paul Eggert <eggert@cs.ucla.edu>
To: Pip Cet <pipcet@gmail.com>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
"Stefan Monnier" <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: Bug#38708: eq vs eql in byte-compiled code
Date: Thu, 2 Jan 2020 15:12:20 -0800 [thread overview]
Message-ID: <63be4261-6a6d-bff4-fe0d-a90ecfadb29e@cs.ucla.edu> (raw)
In-Reply-To: <CAOqdjBdSZSQoUbe10tx7bc5kqwuC=qG=aYAMOXeNOuEDQtzjfA@mail.gmail.com>
On 1/2/20 4:27 AM, Pip Cet wrote:
> For what it's worth, I'm not seeing that effect, and it seems too
> large to me to be easily explicable.
I'm also puzzled. I reproduced the effect on two smallish hosts (Fedora
31, Ubuntu 18.04.3) running sequentially, but not on a larger one when
running with 'make -j14' (RHEL 7.7). I'll look into it a bit more. Could
be a cache-size issue.
> I might be mistaken, but our hash tables never shrink, do they? That
> sounds like a potential problem to me, particularly for people who
> mess about with gc settings; but I haven't been able to produce a
> problem in practice with your patch.
You're right they don't shrink. However, on today's machines I expect
that the only problem would be that a hash table too large for its
number of entries would not cache as well.
>> * Should we try hash-consing floats too? Maybe it wouldn't be as slow as we
>> thought, for typical computations anyway....
>
> I think the answer is yes here...
>
>> * The attached patch could probably be sped up a bit by supporting sets as well
>> as mappings at the low level, since bignum_map is really just a set of bignums.
>> Not sure it's worth the effort, though.
>
> if it's also yes here.
More things for me to look into, I suppose...
next prev parent reply other threads:[~2020-01-02 23:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 15:07 Bug#38708: eq vs eql in byte-compiled code Pip Cet
2019-12-31 15:51 ` Andrea Corallo
2019-12-31 16:05 ` Mattias Engdegård
2019-12-31 17:38 ` Paul Eggert
2020-01-01 12:38 ` Mattias Engdegård
2020-01-02 8:38 ` Paul Eggert
2020-01-02 17:26 ` Mattias Engdegård
2020-01-04 19:55 ` Stefan Monnier
2020-01-22 10:56 ` Mattias Engdegård
2020-01-25 0:59 ` Paul Eggert
2020-01-01 15:45 ` Stefan Monnier
2020-01-02 7:52 ` Paul Eggert
2020-01-02 12:27 ` Pip Cet
2020-01-02 23:12 ` Paul Eggert [this message]
2020-01-02 13:48 ` Eli Zaretskii
2020-01-04 18:54 ` Stefan Monnier
2020-01-04 19:33 ` Paul Eggert
2020-01-04 19:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63be4261-6a6d-bff4-fe0d-a90ecfadb29e@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).