unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,  emacs-devel@gnu.org
Subject: Re: master 8ee21db4af: Add new function `read-string-from-buffer'.
Date: Fri, 29 Apr 2022 08:20:25 -0400	[thread overview]
Message-ID: <jwvtuacf5kl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <YmuziQQMFye96gxL@protected.localdomain> (Jean Louis's message of "Fri, 29 Apr 2022 12:44:41 +0300")

Jean Louis [2022-04-29 12:44:41] wrote:
> (defun read-from-buffer (&optional value buffer-name mode title keymap place
> highlight-list minor-modes)

I'd collapse those "mode title keymap place highlight-list minor-modes"
into a singe `setup-function` argument.

And FWIW, `read-from-buffer` sounds like a good name for a "low-level"
function that parallels `read-from-minibuffer` but using a normal window
rather than a miniwindow, whereas `read-string-from-buffer` sounds like
a replacement for `read-string` (and hence wouldn't take/need
a `setup-function` argument).


        Stefan




  reply	other threads:[~2022-04-29 12:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165080616575.16300.17375829044466066664@vcs2.savannah.gnu.org>
     [not found] ` <20220424131606.1E4FEC009A8@vcs2.savannah.gnu.org>
2022-04-24 14:03   ` master 8ee21db4af: Add new function `read-string-from-buffer' Sean Whitton
2022-04-24 14:07     ` Lars Ingebrigtsen
2022-04-29  9:44     ` Jean Louis
2022-04-29 12:20       ` Stefan Monnier [this message]
2022-04-29 13:18         ` Jean Louis
2022-04-29 13:52           ` Stefan Monnier
2022-05-18  5:17             ` Jean Louis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtuacf5kl.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=spwhitton@spwhitton.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).